Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImgBot] Optimize images #37520

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@MichaelDeBoey
Copy link
Contributor

MichaelDeBoey commented Oct 24, 2019

Beep boop. Your images are optimized!

Your image file size has been reduced by 26% 馃帀

Details
File Before After Percent reduction
/docs/images/devops/travis-build.png 65.11kb 46.87kb 28.02%
/api-server/public/images/freeCodeCamp-puck.svg 2.03kb 2.03kb 0.05%
/client/src/assets/images/freeCodeCamp-404.svg 3.66kb 3.66kb 0.03%
Total : 70.80kb 52.55kb 25.77%

馃摑docs | :octocat: repo | 馃檵issues | 馃弲swag | 馃彧marketplace

*Total -- 70.80kb -> 52.55kb (25.77%)

/docs/images/devops/travis-build.png -- 65.11kb -> 46.87kb (28.02%)
/api-server/public/images/freeCodeCamp-puck.svg -- 2.03kb -> 2.03kb (0.05%)
/client/src/assets/images/freeCodeCamp-404.svg -- 3.66kb -> 3.66kb (0.03%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
@MichaelDeBoey MichaelDeBoey requested a review from freeCodeCamp/dev-team as a code owner Oct 24, 2019
@gitpod-io

This comment has been minimized.

Copy link

gitpod-io bot commented Oct 24, 2019

@MichaelDeBoey

This comment has been minimized.

Copy link
Contributor Author

MichaelDeBoey commented Oct 24, 2019

If you want, you can install https://imgbot.net in this repo (or in the full organization).
It will automatically send PRs for image optimization 馃檪

@ojeytonwilliams

This comment has been minimized.

Copy link
Contributor

ojeytonwilliams commented Oct 28, 2019

Hey @MichaelDeBoey the travis-build change looks good, but the other two just seem to be noise. Is it possible to set a cut-off % below which it doesn't create a PR?

@MichaelDeBoey

This comment has been minimized.

Copy link
Contributor Author

MichaelDeBoey commented Oct 28, 2019

@ojeytonwilliams This is not my bot, I just like it and thought it would be something helpful to use.

From looking into the docs, it seems that it's possible to ignore files, but it's not possible to set a threshold.

@ojeytonwilliams

This comment has been minimized.

Copy link
Contributor

ojeytonwilliams commented Oct 28, 2019

@MichaelDeBoey sorry, didn't mean to imply it was yours! I was just hoping I'd missed that feature somewhere in the docs. Guess not, though.

@raisedadead this does look promising.

@raisedadead raisedadead merged commit c22ca24 into freeCodeCamp:master Oct 31, 2019
2 checks passed
2 checks passed
Gitpod Open an online workspace in Gitpod
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raisedadead

This comment has been minimized.

Copy link
Member

raisedadead commented Oct 31, 2019

I will look into getting this integrated, however we do not have many image changes going on in this repository.

@MichaelDeBoey

This comment has been minimized.

Copy link
Contributor Author

MichaelDeBoey commented Oct 31, 2019

It's handy for each image you have, so that's why I wanted to suggest it 馃檪

@MichaelDeBoey MichaelDeBoey deleted the MichaelDeBoey:imgbot branch Oct 31, 2019
@raisedadead

This comment has been minimized.

Copy link
Member

raisedadead commented Oct 31, 2019

Yup, I do use it on my personal side projects. It's a nifty tool however, I do not see it to be a good fit on this project. Thanks a lot for your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can鈥檛 perform that action at this time.