Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use bash -c to call jest utils when using Windows locally #37680

Merged

Conversation

@RandellDawson
Copy link
Member

RandellDawson commented Nov 4, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #37610

This PR implements to fix discovered by @ojeytonwilliams on issue #37610. I can confirm it works for Windows 10.

@RandellDawson RandellDawson requested a review from freeCodeCamp/dev-team as a code owner Nov 4, 2019
@gitpod-io

This comment has been minimized.

Copy link

gitpod-io bot commented Nov 4, 2019

Copy link
Contributor

ojeytonwilliams left a comment

LGTM 👍

package.json Outdated Show resolved Hide resolved
Co-Authored-By: Valeriy <ValeraS@users.noreply.github.com>
@RandellDawson

This comment has been minimized.

Copy link
Member Author

RandellDawson commented Nov 5, 2019

@ValeraS Your suggestion worked great!

@ValeraS
ValeraS approved these changes Nov 5, 2019
@ValeraS ValeraS merged commit b21ad80 into freeCodeCamp:master Nov 5, 2019
2 checks passed
2 checks passed
Gitpod Open an online workspace in Gitpod
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RandellDawson RandellDawson deleted the RandellDawson:fix/use-bash-c-to-call-jest-utils branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.