Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client,server): usernames should not be a http error code #37804

Merged
merged 2 commits into from Nov 27, 2019

Conversation

@raisedadead
Copy link
Member

raisedadead commented Nov 21, 2019

Handle username restrictions

@raisedadead raisedadead requested a review from freeCodeCamp/dev-team as a code owner Nov 21, 2019
@gitpod-io

This comment has been minimized.

Copy link

gitpod-io bot commented Nov 21, 2019

Copy link
Contributor

ojeytonwilliams left a comment

@raisedadead Everything looks fine, but it occurs to me that it's a tiny bit better to have it reject invalid characters before rejecting short usernames.

If you agree, I can update the tests, otherwise it's good to go.

@raisedadead

This comment has been minimized.

Copy link
Member Author

raisedadead commented Nov 21, 2019

Sure go ahead.

Copy link
Contributor

ojeytonwilliams left a comment

LGTM, but I then just changed it, so I'll not merge it.

@raisedadead raisedadead merged commit 9886cf7 into freeCodeCamp:master Nov 27, 2019
2 checks passed
2 checks passed
Gitpod Open an online workspace in Gitpod
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raisedadead raisedadead deleted the raisedadead:fix/validate-username branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.