Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(donate): handle missing stripe keys #37847

Merged

Conversation

@ojeytonwilliams
Copy link
Contributor

ojeytonwilliams commented Nov 28, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

The first commit prevents production from starting with missing keys while allowing development to start with a warning. If the keys are still missing when the donate page is rendered it handles it gracefully.

The second commit makes sure the flow is state -> render not render -> state. @raisedadead I went through the logic and I'm reasonably confident it's correct i.e. in this PR this.hideAmountOptions(); will now have been called by a handler before render so that we will end up with the same processing state as before.

@ojeytonwilliams ojeytonwilliams requested a review from raisedadead Nov 28, 2019
@ojeytonwilliams ojeytonwilliams requested a review from freeCodeCamp/dev-team as a code owner Nov 28, 2019
@gitpod-io

This comment has been minimized.

Copy link

gitpod-io bot commented Nov 28, 2019

@raisedadead raisedadead merged commit c660b38 into freeCodeCamp:master Nov 29, 2019
2 checks passed
2 checks passed
Gitpod Open an online workspace in Gitpod
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.