Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(client): show certs on timeline #37947
I refactored the selector into the same module as the rest of the selectors, when I thought it would be useful, but left it there since it seems like a better place for it.
This does duplicate the cert info again, so will need refactoring down the line. I think, when the api-server is next overhauled, all the cert info should be moved into one module that's common to both client and server.
Thanks for the pr. The icon looks good and simple. Down the line we could unify all of our icons to make sure they look and feel similar to one another.
As @moT01 mentioned, we should only show the certificate only when the certificates are set to public from the settings