Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): resolving typos and small bugs in JS RPG game #52129

Merged
merged 2 commits into from Oct 28, 2023
Merged

fix(curriculum): resolving typos and small bugs in JS RPG game #52129

merged 2 commits into from Oct 28, 2023

Conversation

jdwilkin4
Copy link
Contributor

Summary of changes

As I was going through the new JS RPG game, I noticed a couple of typos and extra clarifications needed.
Here is the list of changes that I made

  • fixed a typo for incorrect hint text for step 127
  • gave a 1 sentence explanation for strict equality in step 138 since it is not talked about in this project
  • amended the hint text for step 150 to remind campers about spacing
  • altered the starting code for step 160
  • clarified instructions for where to add the newline character in the string for step 165

Checklist:

@jdwilkin4 jdwilkin4 self-assigned this Oct 27, 2023
@jdwilkin4 jdwilkin4 changed the title fix(curriculum): resolving typos and small bugs in JS rpg game fix(curriculum): resolving typos and small bugs in JS RPG game Oct 27, 2023
@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Oct 27, 2023
@ghost
Copy link

ghost commented Oct 27, 2023 •
edited by ghost

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@gikf gikf added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Oct 27, 2023
@Sembauke Sembauke added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Oct 27, 2023
@Hacakr7770

This comment was marked as off-topic.

Sign in to view
@jdwilkin4 @huyenltnguyen @Sembauke
Apply suggestions from code review
b977d23 
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
Co-authored-by: Sem Bauke <semboot699@gmail.com>
@jdwilkin4 jdwilkin4 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Oct 27, 2023
@jdwilkin4 jdwilkin4 enabled auto-merge (squash) October 27, 2023 18:16
@jdwilkin4 jdwilkin4 merged commit 0a74f48 into freeCodeCamp:main Oct 28, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hacakr7770 Hacakr7770 Hacakr7770 left review comments

@Sembauke Sembauke Sembauke approved these changes

@gikf gikf gikf approved these changes

@huyenltnguyen huyenltnguyen Awaiting requested review from huyenltnguyen

Assignees

@jdwilkin4 jdwilkin4

Labels
front 3 2023 scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdwilkin4 @Hacakr7770 @huyenltnguyen @Sembauke @gikf