Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: social bar #23

Merged
merged 13 commits into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@ahmadabdolsaheb
Copy link
Member

commented Jun 13, 2019

No description provided.

@ahmadabdolsaheb ahmadabdolsaheb force-pushed the ahmadabdolsaheb:feat/social-byline branch from 46ae408 to 2ccefee Jun 18, 2019

@ahmadabdolsaheb ahmadabdolsaheb marked this pull request as ready for review Jun 18, 2019

@ahmadabdolsaheb ahmadabdolsaheb force-pushed the ahmadabdolsaheb:feat/social-byline branch from 5e925ef to 3e4483e Jun 19, 2019

@ahmadabdolsaheb

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

the social icon bar is still the full width of the feed because it also appear at the end of the article content and act as a divider. having them in another size would look strange.

they change background color on hover and select. ( to border color)

twitter will include author handle if author object has twitter.

the floating nav bar and progress bar are removed.

Screen Shot 2019-06-19 at 7 19 10 PM

Screen Shot 2019-06-19 at 7 19 43 PM

@raisedadead
Copy link
Member

left a comment

Use white for the color on hover.

image

@raisedadead

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

Also, make sure that the brand guidelines are followed with respect to twitter and facebook. I am sure we haven't gotten it wrong, but just double check.

@raisedadead
Copy link
Member

left a comment

image

@mention required for authors?

@ahmadabdolsaheb

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

Changed the icons and spacing according to fb,twitter guidelines;
Changed items colors on hover;

The at mention works on my side.
could you try it with another author account or your personal account.

Screen Shot 2019-06-20 at 11 18 56 AM

@raisedadead raisedadead merged commit b158341 into freeCodeCamp:master Jun 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.