This repository has been archived by the owner on May 30, 2023. It is now read-only.
fix: assert time-left is formatted correctly #772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
master
branch of freeCodeCamp/testable-projects-fccfix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm run build
Type of Change
Checklist:
Description
This PR fixes an assertion issue for the pomodoro clock testing project. The issue was that all tests pass even if the
time-left
was incorrectly formatted as00:00
instead of60:00
when session length is set to60
The following screenshots demonstrate the fix
An example project before the fix can be found here: https://abdusabri.github.io/fcc-pomodoro-bug/
An example project after the fix can be found here: https://abdusabri.github.io/fcc-pomodoro-fix/