Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix six problems about [L/R]TrimAny library functions. #116

Closed
skyfish4tb opened this issue Nov 30, 2018 · 4 comments · Fixed by #143

Comments

@skyfish4tb
Copy link
Contributor

commented Nov 30, 2018

Unnecessary multiple lookups:
l r trim

@countingpine

This comment has been minimized.

Copy link
Collaborator

commented Dec 5, 2018

If you think these changes are worth committing, it might be better to submit this as a pull request.
For what it's worth though, I'm impressed you managed to capture that as a screenshot. You must have a very tall monitor :)

@sancarn

This comment has been minimized.

Copy link

commented Jan 8, 2019

@countingpine They likely used a scrolling screenshot 😛 At least you can do that with ShareX

@rversteegen

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

Firefox can take screenshots of page elements like that.

Anyway, this seems to be part of this commit:
skyfish4tb@0e4c0da
But it's mixed in with a lot of other changes.

@jayrm

This comment has been minimized.

Copy link
Collaborator

commented May 4, 2019

@skyfish4tb,
Is skyfish4tb@0e4c0da the correct commit to be looking at?

The commit message says: "2. The optimization of [L/R]TrimAny function code."

Does the change fix problems? If yes, what were the failed cases?
Or this change is only an optimization?

I was working on some issues related to the wstring [L|R]TRIM functions in #142

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.