fbc-tests: wstring and DOS compatibility #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jayrm
commented
Aug 26, 2019
jayrm
commented
- in DOS fbc, cast the return value in ASC(wstring,index) to 'unsigned char', because previously ASC() was returning 'char' incorrectly sign extended to 32 bits. And changing FB_WCHAR to 'unsigned char' causes too many compile warnings.
- in tests/fbc-tests.bas allow '-no-error' option to ignore failed test suite by not returning with exit error code
- suppress failed tests in tests/string/format.bas on mingw-org - can be enable with ENABLE_CHECK_BUGS
- suppress tests for wstring USC2 chars on DOS, an FB_WCHAR of 1 byte can not hold UCS2 chars.
- in DOS fbc, cast the return value in ASC(wstring,index) to 'unsigned char', because previously ASC() was returning 'char' incorrectly sign extended to 32 bits. And changing FB_WCHAR to 'unsigned char' causes too many compile warnings. - in tests/fbc-tests.bas allow '-no-error' option to ignore failed test suite by not returning with exit error code - suppress failed tests in tests/string/format.bas on mingw-org - can be enable with ENABLE_CHECK_BUGS - suppress tests for wstring USC2 chars on DOS, an FB_WCHAR of 1 byte can not hold UCS2 chars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.