Checkers #316
Merged
Checkers #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
|
This looks really good! I will do some more testing tomorrow and we can merge soon |
vdfdev
commented
Jul 13, 2019
| expect(move(G, ctx, { x: 1, y: 0 }, { x: 4, y: 4 })).toEqual(INVALID_MOVE); | ||
| }); | ||
|
|
||
| it('should declare player 1 as the winner', () => { |
There was a problem hiding this comment.
Can you add some specific tests for some corner cases like the double jump ? Some interesting test cases:
- double jump
- when the piece becomes king
- king jumping backwards
src/games/checkers/game.ts
Outdated
| let moves: IMove[] = []; | ||
| let jumped = false; | ||
|
|
||
| dirs.forEach(dir => { |
There was a problem hiding this comment.
Why not use:
for (const dir of does) ?
src/games/checkers/game.ts
Outdated
| return a.x === b.x && a.y === b.y; | ||
| } | ||
|
|
||
| export function checkPosition(G: IG, playerID: string, piece: ICheckerPiece, coord: ICoord) { |
There was a problem hiding this comment.
Can you make the return type explicit?
|
|
||
| const piece = (id: number, player: number): ICheckerPiece => ({ id, playerID: player.toString(), isKing: false }); | ||
|
|
||
| export const INITIAL_BOARD: Piece[] = [ |
There was a problem hiding this comment.
Smart to make one dimensional :)
jasonharrison
approved these changes
Jul 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.