From 655a704986632b3404272af46d8389274f5c25b8 Mon Sep 17 00:00:00 2001
From: "Lev A. Serebryakov" <lev@FreeBSD.org>
Date: Wed, 13 Apr 2022 21:25:49 +0300
Subject: [PATCH] devel/subversion-lts: Make all binaries stripping explicit.

  Running ${STRIP_CMD} on non-binary file can left zero-length
 temporary file.

  Strip all binaries explicitly, with list of them and loop, instead
 of calling ${STRIP_CMD} with '*'.
---
 devel/subversion-lts/Makefile | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/devel/subversion-lts/Makefile b/devel/subversion-lts/Makefile
index 67031041bdb92..4e9dbc9b15351 100644
--- a/devel/subversion-lts/Makefile
+++ b/devel/subversion-lts/Makefile
@@ -132,6 +132,14 @@ LIBS+=		${LIBS_SQLITE3}
 LIBS+=		-lc++ -lm
 .endif
 
+BINS_TO_STRIP= svn svnadmin svnbench svndumpfilter svnfsfs svnlook svnmucc \
+		svnrdump svnserve svnsync svnversion
+
+TOOLS_TO_STRIP=	fsfs-access-map svn-mergeinfo-normalizer \
+		 svn-populate-node-origins-index svnauthz \
+		 svnauthz-validate svnconflict svndiff svndiff3 \
+		 svndiff4 svnmover svnraisetreeconflict x509-parser
+
 post-configure:
 # Enable GNOME Keyring / KWallet support in main code, as it is harmless
 	@${REINPLACE_CMD} -E 's%.*#undef SVN_HAVE_(GNOME_KEYRING|KWALLET).*%#define SVN_HAVE_\1 1%' ${WRKSRC}/subversion/svn_private_config.h
@@ -149,7 +157,9 @@ post-build-TOOLS-on:
 	@${MAKE} -C ${WRKSRC} tools ${MAKE_ARGS}
 
 post-install:	${MKREPOS_TARGET}
-	-@${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/*
+	for F in ${BINS_TO_STRIP} ; do \
+	 ${STRIP_CMD} "${STAGEDIR}${PREFIX}/bin/$${F}" ; \
+	done
 	@${MKDIR} ${STAGEDIR}${DATADIR}
 	(cd ${WRKSRC}/tools.examples && ${TAR} --exclude '*.in' -cf - * | ${TAR} -C ${STAGEDIR}${DATADIR} -xof - )
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
@@ -163,7 +173,9 @@ post-install-SVNSERVE_WRAPPER-on:
 
 post-install-TOOLS-on:
 	@${MAKE} -C ${WRKSRC} install-tools ${MAKE_ARGS}
-	-@${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/*
+	for F in ${TOOLS_TO_STRIP} ; do \
+	 ${STRIP_CMD} "${STAGEDIR}${PREFIX}/bin/$${F}" ; \
+	done
 
 # ===============================================================================
 repository:	_mkrepos