Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

portmgr.adoc: corrections and suggestions #524

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

grahamperrin
Copy link
Contributor

Akinori (not Akonori) according to https://people.freebsd.org/~knu/.

Correct markup for lists (https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#lists "… An empty line is required before and after a list to separate it from other blocks. …"); and for indented list items.

Maybe better to use backticks, not ", to signify commands.

Qt 6 is two words e.g. https://www.qt.io/blog/qt-6.4-released. Or, make it lowercase qt6, if it's as in devel/qt6.

Akinori (not Akonori) according to <https://people.freebsd.org/~knu/>. 

Correct markup for lists (<https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#lists> "… An empty line is required before and after a list to separate it from other blocks. …"); and for indented list items. 

Maybe better to use backticks, not ", to signify commands. 

Qt 6 is two words e.g. <https://www.qt.io/blog/qt-6.4-released>. Or, make it lowercase qt6, if it's as in devel/qt6.
White spaces suggest that Firefox ESR should be nested compared to Firefox.
I omitted to correct the first mistake that I noticed.
@grahamperrin
Copy link
Contributor Author

@debdrup @lsalvadore please, was freebsd/freebsd-doc@4e6d8da intended to address part of this PR?

The commit references bug report 265246, which is not related to the quarterly report.

grahamperrin referenced this pull request in freebsd/freebsd-doc Oct 9, 2022
Add blank lines required to display bullet points properly.

PR:		265246
Reported by:	grahamperrin
Approved by:	debdrup (status blanket)
@lsalvadore
Copy link
Member

lsalvadore commented Oct 9, 2022

@debdrup @lsalvadore please, was freebsd/freebsd-doc@4e6d8da intended to address part of this PR?

It was not intended to address part of this PR since it has been done more than two months before the PR was open. However, the issue fixed there is probably similar to the one you are fixing here.

The commit references bug report 265246, which is not related to the quarterly report.

The first sentence of your bug report is about a quarterly report. Please see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265246 comment 5 for more details.

@grahamperrin
Copy link
Contributor Author

@lsalvadore thanks, now I see. Quarterly reports from portmgr, different reports :-)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265246#c6 goes some way to explaining the confusion.

I should probably make this bull request ready for review …

@grahamperrin grahamperrin marked this pull request as ready for review October 10, 2022 00:45
@pauamma pauamma merged commit 8d4ef98 into freebsd:main Oct 11, 2022
@grahamperrin grahamperrin deleted the patch-10 branch October 11, 2022 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants