asmc: Add support for MacbookPro11,4.#1366
Closed
MegaManSec wants to merge 1 commit intofreebsd:mainfrom
Closed
Conversation
markjdb
reviewed
Aug 23, 2024
markjdb
approved these changes
Aug 23, 2024
Member
markjdb
left a comment
markjdb
left a comment
There was a problem hiding this comment.
Thank you. Please squash the commits together.
Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu>
freebsd-git
pushed a commit
that referenced
this pull request
Aug 26, 2024
Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu> MFC after: 2 weeks Pull Request: #1366
Member
|
Pushed to main, thank you. |
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Dec 3, 2024
Signed-off-by: Joshua Rogers <Joshua@Joshua.Hu> MFC after: 2 weeks Pull Request: freebsd/freebsd-src#1366
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for asmc with the Macbookpro 11.4.
SMCs were (mostly) taken from https://logi.wiki/index.php/SMC_Sensor_Codes.
Three errors occur when running sysctl:
asmc0: asmc_key_read for key F1Sf failed 10 times, giving up
asmc0: asmc_key_read for key F0Sf failed 10 times, giving up
asmc0: asmc_key_read for key F0Sf failed 10 times, giving up
These correspond to:
dev.asmc.0.fan.1.safespeed
dev.asmc.0.fan.0.safespeed
but cannot be disabled without severely altering the driver, so I've left them as-is.
Keyboard backlight is working nicely, and fan and temp reporting is also working.