Update crontab $PATH

[benrubson]

Hi,

This PR sets $PATH in /etc/crontab like it is set by the cron(8) daemon, for consistency.
It then solves https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213742.

Thank you 👍

Ben

[bsdimp]

Cron's default path is actually pathnames.h:# define _PATH_DEFPATH "/usr/bin:/bin". Where do you get that it is PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin?

[benrubson]

From crontab(5) :

Several environment variables are set up automatically by the cron(8)
daemon.  SHELL is set to /bin/sh, PATH is set to
/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin, and LOGNAME
and HOME are set from the /etc/passwd line of the crontab's owner.  HOME,
PATH and SHELL may be overridden by settings in the crontab; LOGNAME may
not.

[bsdimp]

I'm sold. I found that the #define I found was #ifndef _PATH_DEFPATH, which is set globally.

[bsdimp]

r334909

[bsdimp]

And thanks!

[benrubson]

Thank you too @bsdimp 👍
Do you think we could still be in time for a backport to 11.2 ?
Or at least to stable/11 ?
Thank you again !

[bsdimp]

11.2, impossible.
11-stable, quite possible. But you'll have to remind me. I'm likely to forget.