Address the fact that errors from copyout(9) are not properly percolated up on success
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @glebius ! I was wondering if you might be able to review this change. |
ngie-eign
force-pushed
the
bug-232210
branch
2 times, most recently
from
0cf4485
to
3448287
Compare
bsdimp
reviewed
Oct 18, 2018
ngie-eign
force-pushed
the
bug-232210
branch
from
3448287
to
5209996
Compare
ngie-eign
force-pushed
the
bug-232210
branch
from
5209996
to
f09d62b
Compare
|
@bsdimp: could you please review this PR? |
ngie-eign
force-pushed
the
bug-232210
branch
3 times, most recently
from
12dbb89
to
7f9ec8e
Compare
ngie-eign
force-pushed
the
bug-232210
branch
4 times, most recently
from
b0b8941
to
26dfef3
Compare
ngie-eign
force-pushed
the
bug-232210
branch
3 times, most recently
from
9456db9
to
84c89e3
Compare
…lated up on failure Not properly reporting this error can result in values "returned" from `sbytes` being misinterpreted by the caller. Bug: 232210
freebsd-git
pushed a commit
that referenced
this pull request
Feb 29, 2024
Minor bug fixes to man page, tests, fnematch (fixing erroneous output),
string escape sequences and improve flow control by optimizing gototab.
Nov 24, 2023:
Fix issue #199: gototab improvements to dynamically resize the
table, qsort and bsearch to improve the lookup speed as the
table gets larger for multibyte input. thanks to Arnold Robbins.
Nov 23, 2023:
Fix Issue #169, related to escape sequences in strings.
Thanks to Github user rajeevvp.
Fix Issue #147, reported by Github user drawkula, and fixed
by Miguel Pineiro Jr.
Nov 20, 2023:
rewrite of fnematch to fix a number of issues, including
extraneous output, out-of-bounds access, number of bytes
to push back after a failed match etc.
thanks to Miguel Pineiro Jr.
Nov 15, 2023:
Man page edit, regression test fixes. thanks to Arnold Robbins
consolidation of sub and gsub into dosub, removing duplicate
code. thanks to Miguel Pineiro Jr.
gcc replaced with cc everywhere.
Sponsored by: Netflix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes a best effort attempt to ensure that the error returned from
fo_sendfileis preserved for diagnostic reasons.
Bug: 232210
Submitted by: ngie