Make mfiutil show progress print out the elapsed time estimate in a more humanized way
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…portability This is cleanup prior to the proposed functional change in the attached bug. Bug: 225993 Submitted by: Enji Cooper <yaneurabeya@gmail.com>
… more humanized way Prior to this commit, `mfiutil show progress` would print out the time in seconds forcing the user to convert the time to a easier to rationalize quantity. Given that RAID rebuilds sometimes take on the order of hours or days, it is more user friendly to print out the elapsed time in a humanized format, similar to how the ETA time is printed out. Bug: 225993 Submitted by: Enji Cooper <yaneurabeya@gmail.com>
|
Committed as r339344 |
|
Thank you @allanjude! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
mfiutil show progresswould print out the time in seconds forcingthe user to convert the time to a easier to rationalize quantity. Given that RAID rebuilds
sometimes take on the order of hours or days, it is more user friendly to print out the
elapsed time in a humanized format, similar to how the ETA time is printed out.
Bug: 225993
Submitted by: Enji Cooper yaneurabeya@gmail.com