Correctly use BASEDIR when checking for src component #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BASEDIR is used to check to ensure we check sources in the right place as outlined by freebsd@ba040f8#diff-7d334bdfcbfcd070ed2c6a35ada63787. Problem is that when this function is called, BASEDIR is empty because we set it to empty while reading conffile. This change ensures that if basedir is specified in conffile, that is used, if not then command line argument is checked and if that is not present as well then we default to /. Came across this at iocage/iocage#892.
|
@sonicaj This has been fixed (in a slightly different way) in r352542 (https://svnweb.freebsd.org/base?view=revision&revision=352542), which was merged to 11/stable and 12/stable and will be part of 12.1 RELEASE, so this can be closed. (This is 9d50cda on the github mirror) |
|
Thanks @grembo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BASEDIR is used to check to ensure we check sources in the right place as outlined by ba040f8#diff-7d334bdfcbfcd070ed2c6a35ada63787.
Problem is that when this function is called, BASEDIR is empty because we set it to empty while reading conffile. This change ensures that if basedir is specified in conffile, that is used, if not then command line argument
is checked and if that is not present as well then we default to /. Came across this at iocage/iocage#892.