Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geom/journal: Fix typos #884

Closed
wants to merge 1 commit into from
Closed

geom/journal: Fix typos #884

wants to merge 1 commit into from

Conversation

agiUnderground
Copy link
Contributor

Fixed a few typos.

@agiUnderground
geom/journal: Fix typos
e044433 
Fixed a few typos.
@agiUnderground agiUnderground changed the title geom/journal: Typo fixes. geom/journal: Fix typos Nov 2, 2023
@agiUnderground
Copy link
Contributor Author

Hi! Is it normal that PR's are ignored for over a month? I know that my PR is not important; it is not a bugfix, but anyway.

@bsdimp
Copy link
Member

bsdimp commented Dec 19, 2023

Hi! Is it normal that PR's are ignored for over a month? I know that my PR is not important; it is not a bugfix, but anyway.

It's not normal... I usually do a run of these at least once a month... work got busy in October, so I'm behind in landing them. Please accept my apologies for the delay. The change looks perfect as is. About the only thing I can think to ask is there a last name you'd like in your name?

@agiUnderground
Copy link
Contributor Author

About the only thing I can think to ask is there a last name you'd like in your name?

I don't really care about credits; I just want to make FreeBSD a little bit better. I hope that's okay. Thanks!

@bsdimp
Copy link
Member

bsdimp commented Dec 28, 2023

landed. thanks for your contrib and sorry I've been asleep at the wheel... merged!

@bsdimp bsdimp closed this Dec 28, 2023
@bsdimp bsdimp added the merged label Dec 28, 2023
freebsd-git pushed a commit that referenced this pull request Dec 28, 2023
@agiUnderground @bsdimp
geom/journal: Fix typos
e4183f1 
Fixed a few typos.

Reviewed by: imp
Pull Request: #884
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Mar 13, 2024
@agiUnderground @bsdjhb
geom/journal: Fix typos
290b1d6 
Fixed a few typos.

Reviewed by: imp
Pull Request: freebsd/freebsd-src#884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic approved these changes

Assignees
No one assigned
Labels
merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agiUnderground @bsdimp @igalic