quot: Use getopt(3) and show usage() if no arguments #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdimp
reviewed
Jan 2, 2024
usr.sbin/quot/quot.c
Outdated
| int ch; | ||
|
|
||
| if (argc == 1) | ||
| usage(); |
There was a problem hiding this comment.
should this be before or after we parse the args? There's a few 'no sense' combinations that we should likely prohibit and warn about.
like does it make sense to specify -a and also args?
quot is quite old and also not a lot used, so hasn't had the updating for these sorts of things that other programs have had.
There was a problem hiding this comment.
Hopefully fixed.
|
I generally like this. I made a suggestion for maybe going a smidge farther, but apart from asking if the test for no args is in the right place, I like this change. |
freebsd-git
pushed a commit
that referenced
this pull request
Feb 3, 2024
Also update the man page and usage to be a little more accurate with the -a flag. Reviewed by: imp Pull Request: #983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quot: Use getopt(3) and show usage() if no arguments