Permalink
Browse files

Fix the following warning from clang trunk:

usr.sbin/dconschat/dconschat.c:163:65: error: format specifies type 'size_t' (aka 'unsigned int') but the argument has type 'off_t' (aka 'long long') [-Werror,-Wformat]
        snprintf(buf, PAGE_SIZE, "\r\n[dconschat reset target(addr=0x%zx)...]\r\n", dc->reset);
                                                                     ~~^            ~~~~~~~~~
                                                                     %llx

Silence this by casting dc->reset to intmax_t, and using the appropriate
length modifier.  While here, wrap the line to a 80 character margin.

MFC after:	3 days
  • Loading branch information...
1 parent b72da2d commit bb49f23052bc23402ae1276f9b16ac7d9aa8b3c2 @DimitryAndric DimitryAndric committed Mar 19, 2012
Showing with 4 additions and 1 deletion.
  1. +4 −1 usr.sbin/dconschat/dconschat.c
@@ -42,6 +42,7 @@
#include <unistd.h>
#include <fcntl.h>
#include <signal.h>
+#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <termios.h>
@@ -160,7 +161,9 @@ dconschat_reset_target(struct dcons_state *dc, struct dcons_port *p)
if (dc->reset == 0)
return;
- snprintf(buf, PAGE_SIZE, "\r\n[dconschat reset target(addr=0x%zx)...]\r\n", dc->reset);
+ snprintf(buf, PAGE_SIZE,
+ "\r\n[dconschat reset target(addr=0x%jx)...]\r\n",
+ (intmax_t)dc->reset);
write(p->outfd, buf, strlen(buf));
bzero(&buf[0], PAGE_SIZE);
dwrite(dc, (void *)buf, PAGE_SIZE, dc->reset);

0 comments on commit bb49f23

Please sign in to comment.