Permalink
Browse files

[psm] Fix calculation for clickpad softbuttons at the top

On laptops like the ThinkPad X240, ClickPad buttons are located at the
top. The hw.psm.synaptics.softbuttons_y sysctl was supposed to allow this
by setting the value to a negative one (e.g. -1700). However, the
condition was wrong (double negative), and doing that placed the buttons
in an unreachable area.

PR:		216342
Submitted by:	Greg V <greg@unrelenting.technology>
MFC after:	1 week
  • Loading branch information...
1 parent 7897540 commit cb4c9500e5fc85fcd2944a205d55a67cf9be5171 @gonzoua gonzoua committed Feb 15, 2017
Showing with 1 addition and 1 deletion.
  1. +1 −1 sys/dev/atkbdc/psm.c
@@ -3194,7 +3194,7 @@ psmgestures(struct psm_softc *sc, finger_t *fingers, int nfingers,
if (sc->synhw.capClickPad && ms->button & MOUSE_BUTTON1DOWN) {
y_ok = sc->syninfo.softbuttons_y >= 0 ?
start_y < sc->syninfo.softbuttons_y :
- start_y > max_y - sc->syninfo.softbuttons_y;
+ start_y > max_y + sc->syninfo.softbuttons_y;
center_button = MOUSE_BUTTON2DOWN;
center_x = sc->syninfo.softbutton2_x;

0 comments on commit cb4c950

Please sign in to comment.