Skip to content
Commits on Oct 11, 2012
  1. MFC @ r238400

    attilio committed Oct 11, 2012
  2. @emaste

    Exclude potential circular symlink when creating src tarball.

    Normal release builds are not affected by this but it can happen if using
    these release bits against a work tree.
    Sponsored by: ADARA Networks
    emaste committed Oct 11, 2012
  3. - Fix grammar [1].

    - Remove /dev/fuseN occurrences and use correct /dev/fuse one.
    [1] Submitted by:	Kevin Oberman <kob6558 AT gmail DOT com>
    Reviewed by:	gjb (partially)
    attilio committed Oct 11, 2012
  4. @AlexanderChernikov

    Add NG_NETFLOW_V9INFO_TYPE command to be able to request netflowv9-sp…

    Submitted by:	Dmitry Luhtionov <dmitryluhtionov at>
    MFC after:	2 weeks
    AlexanderChernikov committed Oct 11, 2012
  5. @amotin

    Increase device CCB queue array size by CAM_RL_VALUES - 1 (4) elements.

    It is required to store extra recovery requests in case of bus resets.
    On ATA/SATA this fixes assertion panics on HEAD with INVARIANTS enabled or
    possible memory corruptions otherwise if timeout/reset happens when device
    CCB queue is already full.
    Reported by:	gibbs@
    MFC after:	1 week
    amotin committed Oct 11, 2012
  6. @stefanfarf
  7. @stefanfarf

    Decode the first two fstab fields with strunvis(3). This allows havin…

    …g spaces
    in devices and mount paths, encoded as \s or \040.
    PR:		bin/117687
    Submitted by:	Martin Kammerhofer
    Discussed on:	arch
    stefanfarf committed Oct 11, 2012
  8. @stefanfarf
  9. Add APE firmware support and improve firmware handshake procedure.

    This change will enable IPMI access on 5717/5718/5719/5720 and 5761
    controllers. Because ASF is not available when APE firmware is
    present, bge_allow_asf tunable is ignored when driver detects APE
    firmware.  Also bge(4) no longer performs two resets(one blind
    reset and the other reset with firmware in mind) in device attach.
    Now bge(4) performs a reset with enough information in bge_reset().
    The APE firmware also needs special handling to make suspend/resume
    work but it was not implemented yet.
    With this change, bge(4) should work on any 5717/5718/5719/5720
    controllers. Special thanks to Mike Hibler at Emulab who setup
    remote debugging on Dell R820. Without his help I couldn't be able
    to address several issues happened on Dell Rx20 systems. And many
    thanks to Broadcom for continuing to support FreeBSD!
    Submitted by:	davidch (initial version)
    H/W donated by:	Broadcom
    Tested by:	many
    Tested on:	Del R820/R720/R620/R420/R320 and HP Proliant DL 360 G8
    yongari committed Oct 11, 2012
  10. For 5717C/5719C/5720C and 57765 PHYs, do not perform any special

    handling(jumbo, wire speed etc) in brgphy_reset().  Touching
    BRGPHY_MII_AUXCTL register seems to confuse APE firmware such that
    it couldn't establish a link.
    yongari committed Oct 11, 2012
  11. Rework controller reset procedure. Previously driver saved

    BGE_PCI_PCISTATE register before issuing global reset. After
    issuing reset, it reads BGE_PCI_PCISTATE register again and
    compares the saved register value and current value. It was used to
    know whether the global reset operation was completed or not.
    Unfortunately, this logic caused several issues on recent BCM5717/
    5718/5719 and BCM5720 controllers. It seems APE firmware accesses
    some registers while global reset is in progress such that reading
    BGE_PCI_PCISTATE register after reset does not yield old pre-reset
    state value. This resulted in consuming too much time in global
    reset and sometimes it couldn't successfully complete reset.
    self-clearing bit so driver is able to know the reset completion.
    But the core-lock reset will disable indirect/flat/standard access
    modes such that driver cannot poll BGE_MISCCFG_RESET_CORE_CLOCKS
    bit of BGE_MISC_CFG register. So just wait enough time for
    core-clock reset to complete.
    Data sheet says driver should wait 100us for PCI/PCI-X devices and
    100ms for PCIe devices. I chose 1ms for PCI/PCI-X since this value
    was used for many years in bge(4). For PCIe devices, use 100ms as
    recommended by data sheet.
    bge_chipinit() also cleared BGE_MAC_MODE register which shall clear
    firmware configured mode information. I think this will result in
    losing ASF/IPMI link in device attachment. Let bge_reset() honor
    firmware configured BGE_MAC_MODE register and don't announce driver
    is UP in bge_reset(). Firmware should have control over driver until
    it's fully initialized by driver.
    While I'm here, enable workaround for PCI-X BCM5704 A0 in
    bge_reset(). This will prevent internal arbitration logic from
    switching to the other DMA engine after a retry cycle.
    yongari committed Oct 11, 2012
Commits on Oct 10, 2012
  1. @jimharris

    Count number of times each queue pair's interrupt handler is invoked.

    Also add sysctls to query and reset each queue pair's stats, including
    the new count added here.
    Sponsored by:	Intel
    jimharris committed Oct 10, 2012
  2. @jimharris

    Put the nvme_qpair mutex on its own cacheline.

    Sponsored by:	Intel
    jimharris committed Oct 10, 2012
  3. @amotin

    - Remove ancient checks for sim->softc == NULL. It can't be NULL, as…

    … it is
    set not-NULL during SIM registration and set to UMASS_GONE on destruction.
    Debug messages there look broken for at least 9 years, as they dereference
    softc value that was just checked to be equal to NULL.
     - Remove magic pointer value UMASS_GONE and use simple NULL instead.
    Found by:	Clang Static Analyzer
    amotin committed Oct 10, 2012
  4. @jimharris

    Add man pages for nvme(4) and nvd(4).

    Sponsored by:	Intel
    Reviewed by:	joel
    jimharris committed Oct 10, 2012
  5. @DimitryAndric

    Pull in r164132 from upstream llvm trunk:

      When creating MCAsmBackend pass the CPU string as well. In X86AsmBackend
      store this and use it to not emit long nops when the CPU is geode which
      doesnt support them.
      Fixes PR11212.
    Pull in r164133 from upstream clang trunk:
      Follow up on llvm r164132.
    This should prevent illegal instructions when building world on Geode
    CPUs (e.g. Soekris).
    MFC after:	3 days
    DimitryAndric committed Oct 10, 2012
  6. @DimitryAndric

    Pull in r163710 from upstream llvm trunk:

      Add support for AMD Geode.
    MFC after:	3 days
    DimitryAndric committed Oct 10, 2012
  7. @amotin

    NULL-ify last previously used pointer instead of last possible pointer.

    This should be only a cosmetic change.
    Found by:	Clang Static Analyzer
    amotin committed Oct 10, 2012
  8. Add a "clearstats" subcommand to cxgbetool that lets you clear the

    MAC statistics for any port.
    For example:
    # cxgbetool t4nex0 clearstats 0
    Submitted by:	gnn@
    MFC after:	3 days
    np committed Oct 10, 2012
  9. @delphij

    Upgrade to 9.8.3-P4:

    Prevents a lockup when queried a deliberately constructed combination
    of records. [CVE-2012-5166]
    For more information:
    delphij committed Oct 10, 2012
  10. @amotin

    panic() with reasonable message instead of returning zero frequency c…

    division by zero later if event timer's minimal period is above one second.
    For now it is just a theoretical possibility.
    Found by:	Clang Static Analyzer
    amotin committed Oct 10, 2012
  11. @amotin

    There are SCSI conditions that are not an errors. In those cases cder…

    returns zero while request status is not CAM_REQ_CMP.  That could cause
    partial device attach or other unexpected results.
    Found by:	Clang Static Analyzer
    amotin committed Oct 10, 2012
  12. Add a driver ioctl to clear a port's MAC statistics.

    Submitted by:	gnn@
    MFC after:	3 days
    np committed Oct 10, 2012
  13. @AlexanderChernikov

    Do not check if found IPv4 rte is dynamic if net.inet.icmp.drop_redir…

    …ect is
    enabled. This eliminates one mtx_lock() per each routing lookup thus improving
    performance in several cases (routing to directly connected interface or routing
    to default gateway).
    Icmp redirects should not be used to provide routing direction nowadays, even
    for end hosts. Routers should not use them too (and this is explicitly restricted
    in IPv6, see RFC 4861, clause 8.2).
    Current commit changes rnh_machaddr function to 'stock' rn_match (and back) for every
    AF_INET routing table in given VNET instance on drop_redirect sysctl change.
    This change is part of bigger patch eliminating rte locking.
    Sponsored by:	Yandex LLC
    MFC after:	2 weeks
    AlexanderChernikov committed Oct 10, 2012
  14. @amotin

    Really handle xpt_compile_path() error in xpt_bus_register() instead of

    print error message and probably crash just after it on NULL dereference.
    Found by:	Clang Static Analyzer
    amotin committed Oct 10, 2012
  15. @amotin

    Remove 'periph == NULL' check from bunch of periph drivers.

    This condition can never be true as functions are called from single place
    and the checks just pollute the code and confuse Clang Static Analyzer.
    amotin committed Oct 10, 2012
  16. @jimharris

    Add support for locate LED.

    While here, change ISCI_LED to ISCI_PHY since conceptually the hardware
    ties the LEDs to a phy and the LEDs for a given phy cannot be controlled
    Submitted by: Paul Maulberger <Paul.Maulberger at> (with modifications)
    jimharris committed Oct 10, 2012
  17. @amotin

    Add checks for ata_sata_scr_read() return statuses. It is mostly to s…

    Clang Static Analyzer warnings as errors there are usually unlikely.
    amotin committed Oct 10, 2012
  18. Add an "i2c" subcommand to cxgbetool. You can use this to read

    information from the transceivers connected to the ports of a
    cxgbe(4) based card.
    # cxgbetool t4nex0 i2c <port_id> <dev_addr> <addr> [<count>]
    For example:
    # cxgbetool t4nex0 i2c 0 0xa0 3
    0x10 [16]
    (As per SFF-8472 the SFP+ module is at 0xa0 and bit 4 in the value at
    address 3 indicates it's a 10Gbase-SR module, which it is.)
    np committed Oct 10, 2012
  19. MFi386 r241356

      Add several asserts.
    MFC after:	3 days
    alc committed Oct 10, 2012
  20. Add a driver ioctl to read a byte from any device on a port's i2c bus.

    This lets userspace read arbitrary information from the SFP+ modules
    etc. on this bus.
    Reading multiple bytes in the same transaction isn't possible right now.
    I'll update the driver once the chip's firmware supports this.
    MFC after:	3 days
    np committed Oct 10, 2012
  21. There is no need to report the same error twice.

    MFC after:	3 days
    np committed Oct 10, 2012
  22. Remove unused item. cxgbe's rx queue's lock was removed a long time ago.

    MFC after:	3 days
    np committed Oct 10, 2012
  23. @bsdjhb

    WITH_CTF is now a "normal" build option (WITHOUT_CTF is supported and

    MK_CTF is used internally).
    Reviewed by:	fjoe
    bsdjhb committed Oct 10, 2012
  24. @bsdjhb

    - Fix the error message when a dependency string is not provided to

      reference a missing dependency rather than a missing compile command.
    - Don't append a newline to the auto-generated compile command.  The
      compile command has a newline appended when it is later output to the
    MFC after:	2 weeks
    bsdjhb committed Oct 10, 2012
Something went wrong with that request. Please try again.