Fix support of user-class option in dhclient #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
added a commit
to dumbbell/freebsd-src
that referenced
this pull request
Sep 6, 2016
* drm: Move sysctl tree init/cleanup in drm_debugfs.c Before, the sysctl tree was initialized from drm_sysfs.c. However, it was never destroyed on unload and, unfortunately, there is no good place to do it. In particular, it is too late in drm_sysfs_release() because the device private data pointer (device_get_drvdata()) is already cleared. Therefore, the initialization and cleanup are made from drm_debugfs.c. * linux_fb.c: Do not clear fb_helper->fbdev in unregister_framebuffer() This leaked memory: framebuffer_release() is supposed to free that memory and clear the pointer, but it obviously couldn't do much. * linux_fb.c: Free `info` after freeing struct members "Fortunately", framebuffer_release() was never called because of the bug fixed in the previous commit, so it never crashed. * drm/i915: Remove intel_fb.c This is a leftover from HEAD's DRM and is no longer compiled in the driver. Furthermore, it made debugging framebuffer more complicated because I was looking at the wrong file... * drm: Remove trailing whitespaces in drm_sysctl.c
|
FreeBSD doesn't take PRs directly, sorry. But I've posted the change in our code review system and have taken assignment of the bug. Here's the link: https://reviews.freebsd.org/D7911 |
|
Thank you. I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dhclientdoes not send theuser-classoption (77) because it's not in the default dhcp option priority list, as reported in Bug 184117.