Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the NetBSD test suite runs OK #16

Closed
jmmv opened this issue Feb 22, 2014 · 2 comments
Closed

Ensure the NetBSD test suite runs OK #16

jmmv opened this issue Feb 22, 2014 · 2 comments
Labels

Comments

@jmmv
Copy link
Member

jmmv commented Feb 22, 2014

From jmmv@google.com on March 19, 2011 10:54:48

The main (and probably major) consumer of ATF at this point is the NetBSD test suite. We must ensure that the test results delivered by Kyua do not deviate from those of ATF. I am aware that at the problem this is not true, so this issue is intended to fix all the problems in this area.

Original issue: http://code.google.com/p/kyua/issues/detail?id=16

@jmmv
Copy link
Member Author

jmmv commented Feb 22, 2014

From jmmv@google.com on March 20, 2011 15:20:11

This issue was updated by revision r95 .

We need to implement integration tests and add this particular case to
them. The unit tests we currently have are very good know but they will
be brittle during future refactorings.

@jmmv
Copy link
Member Author

jmmv commented Feb 22, 2014

From jmmv@google.com on June 07, 2011 07:17:41

Some integration tests for the cli-side of the tool have been added. While thinking of adding more integration tests for things like isolation and requirements checking, I realized it is a waste of time to do it now: such things are already very well-tested in their corresponding module-specific tests, and duplicating the tests (in a slower language: sh) will not help much.

I have just run the recent test suite from NetBSD both as root and as a regular user and the results Kyua yields are the same as those produced by atf-run. Modulo regressions later on, this ticket provides no additional value and can be closed. We now have all the required functionality implemented!

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant