New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quote $KERNEL not only when checked, also when used #819
Conversation
since -K kernel could be a list, we should quote it when we use it, not only when checking if it's set.
df9dcac
to
c3f6337
Compare
LGTM |
finally have actually time to test this: compile goes thru, but no GENERIC-NODEBUG kernel package is created: https://alpha.pkgbase.live/FreeBSD:13:amd64/13.0.s20210109160611/ |
our documentation https://wiki.freebsd.org/PkgBase suggests that KERNCONF needs to be set in make.conf, but we set export __MAKE_CONF=/dev/null that means that all `make` arguments must be passed explicitly.
frustratingly, even after f1b60ab the result is still the same, https://alpha.pkgbase.live/FreeBSD:13:amd64/13.0.s20210110155125/ |
so the issue may be with update-packages / -u, so I'm now trying a run where i rebuild the jail from scratch |
after recreating the jail, with the same name, it still doesn't work |
now I'm wondering if i also need to throw away existing images before trying this again |
Something is broken in base, this isn't a problem with poudriere. |
okay, so let's merge this for now, since at least it makes poudriere complete the compilation. is the other kernel absorbed into the generic package or into the utilities package, or is it really not packaged at all? |
To be clear, is this PR ready for merge? |
My last build was 429c7d1ab4c0f56495e7b2e4acd15df91cbc14ab and this worked fine at that point, though I don't specifically build GENERIC/GENERIC-NODEBUG (was that a typo? you wrote GENERIC-DEBUG) but rather a bunch of other custom kernels:
[edit] Here's some relevant details:
So NO_INSTALLEXTRAKERNELS=no to make(1) combined with KERNCONF does the trick here (KERNCONF is also specified as a make arg, but it was omitted here) |
since -K kernel could be a list, we should quote it when we use it, not
only when checking if it's set.
This pull request fixes part of #818, namely the build error in poudriere.