Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BusWrapper API Update #1190

Merged
merged 17 commits into from Mar 1, 2018

Conversation

Projects
None yet
4 participants
@hcook
Copy link
Contributor

commented Jan 12, 2018

  • Rename coreplex => subsystem
  • New TLBusWrapper attachment API
  • Further tweaks to LazyModule instance name inference

@hcook hcook requested a review from aswaterman Jan 12, 2018

@hcook hcook force-pushed the bus-api branch from 30e7e79 to 01b2996 Jan 18, 2018

@hcook hcook force-pushed the bus-api branch from 01b2996 to a67a3a5 Feb 15, 2018

@hcook hcook requested a review from terpstra Feb 15, 2018

@hcook hcook changed the title Rename coreplex => subsystem BusWrapper API Update Feb 15, 2018

@terpstra
Copy link
Contributor

left a comment

Have fun updating all the submodules...

@hcook

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2018

Oh i will

@terpstra

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2018

My fear is module names will be very unstable now.

@hcook hcook force-pushed the bus-api branch from 39c71f5 to eaa908d Feb 21, 2018

@hcook hcook force-pushed the bus-api branch from 820f759 to 30c0635 Feb 23, 2018

@hcook hcook merged commit 20a8876 into master Mar 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@edcote

This comment has been minimized.

Copy link
Contributor

commented on src/main/scala/subsystem/FrontBus.scala in 3f436a7 Mar 14, 2018

@hcook
Do you have anything that explains the new API?
If so, can you help shed some light on these changes? The result appears much less elegant and more difficult to understand.

This comment has been minimized.

Copy link
Contributor

replied Mar 14, 2018

Is it also possible that specification of crossTLIn/Out is required. I seem to be hitting sync_xing assertions (incorrect inptus and outputs). They did not appear (not 100% certain) to be there before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.