New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove riscv tools #1601

Merged
merged 2 commits into from Nov 15, 2018

Conversation

Projects
None yet
6 participants
@terpstra
Copy link
Contributor

terpstra commented Aug 24, 2018

Type of change: other enhancement

Impact: API modification

Development Phase: proposal

Release Notes
Removed riscv-tools from rocket-chip

The software ecosystem is now mostly stable. There are work-arounds to avoid bringing the giant riscv-tools into the tree for most projects using rocket. This PR makes their life easier.

@mwachs5
Copy link
Contributor

mwachs5 left a comment

it would be even more useful if the different sub-tools could be referenced differently. So that you don't need to recompile GCC just because you changed the version of riscv-tests.
but maybe that's a later PR?

@terpstra terpstra force-pushed the remove-riscv-tools branch from d7088d9 to 35ff669 Aug 24, 2018

@terpstra

This comment has been minimized.

Copy link
Contributor

terpstra commented Aug 24, 2018

If you are talking about how we pull in riscv-tools for travis, that could be a follow-up commit. If you are talking about how this works for end-users, I think the answer should be: package management.

@hcook

hcook approved these changes Aug 27, 2018

@palmer-dabbelt
Copy link
Contributor

palmer-dabbelt left a comment

I'm happy with this: riscv-tools is pretty crusty anyway, and now that many distros have native RISC-V toolchains it seems unnecessary.

@terpstra terpstra force-pushed the remove-riscv-tools branch from 35ff669 to f4c47a7 Aug 28, 2018

@wsong83 wsong83 referenced this pull request Aug 28, 2018

Merged

bi-weekly news 2018-09-01 #115

6 of 7 tasks complete

@samh-sifive samh-sifive force-pushed the remove-riscv-tools branch from 495350c to 3a427a3 Nov 14, 2018

terpstra and others added some commits Aug 24, 2018

Remove riscv-tools submodule and store the desired hash in riscv-tool…
…s.hash. Update the

makefile rules to checkout and build using this hash.
Change riscv-tools install rule so checkout is an order-requ rather t…
…han dependency. This is to

ensure that a cached install, if present, is used.

@samh-sifive samh-sifive force-pushed the remove-riscv-tools branch from 3a427a3 to ee21bb2 Nov 15, 2018

@samh-sifive samh-sifive merged commit 7c415ea into master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aswaterman aswaterman deleted the remove-riscv-tools branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment