Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cargo-sweep.sh #214

Merged
merged 5 commits into from
Jun 21, 2019
Merged

Conversation

pzmarzly
Copy link
Collaborator

@pzmarzly pzmarzly commented Jun 9, 2019

See conversation in #212. cargo-sweep will no longer print "error" when cargo-sweep is already installed. Also, updating it should now work.

It will no longer print "error" when cargo-sweep is already installed.
Also, updating should now work.
@realcr
Copy link
Member

realcr commented Jun 10, 2019

@pzmarzly : Thanks, I will merge this. I noticed some strange error in one of the integration tests in macOS, I try to restart it. I will check it later and fix if necessary in another PR.

@pzmarzly
Copy link
Collaborator Author

I also experienced the same issue in #215 after Apply cargo fmt commit, restarting the macOS job helped.

@realcr
Copy link
Member

realcr commented Jun 15, 2019

I also experienced the same issue in #215 after Apply cargo fmt commit, restarting the macOS job helped.

I added some code to document what happens in the bad integration test (On MacOS). Next time it happens could you include the error? I'm very interested to see what happens there. My guess is some kind of networking problem.

@realcr
Copy link
Member

realcr commented Jun 15, 2019

@pzmarzly : I think that I fixed the macOS bug, but I accidentally pushed the fix directly into master. Sorry about that \:

@pzmarzly
Copy link
Collaborator Author

Ready for merging

@realcr
Copy link
Member

realcr commented Jun 20, 2019

@pzmarzly : Thanks! Could you check my question above about duplicate if clause in the bash script? Is there a way we can make it more compact?
EDIT: Only now I realized I didn't click on the "request changes". Maybe my question wasn't visible until now (: Sorry!

travis/trusty/post/cargo-sweep.sh Outdated Show resolved Hide resolved
@realcr
Copy link
Member

realcr commented Jun 21, 2019

@pzmarzly : Thanks!

@realcr realcr merged commit b21aff6 into freedomlayer:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants