Skip to content

Multi Currency feature #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 156 commits into from
Oct 21, 2019
Merged

Multi Currency feature #240

merged 156 commits into from
Oct 21, 2019

Conversation

realcr
Copy link
Member

@realcr realcr commented Sep 27, 2019 •
edited
Loading

Allows to use multiple currencies with Offst.

  • Currencies are short strings (For example: "FST", "USD") that are chosen by the user.
  • All currencies are multiplexed together on one token channel.
  • Implemented automatic currencies negotiation between friends.

Attempts to solve issue #228, as suggested by @bltavares .

realcr added 30 commits September 27, 2019 15:52
@realcr
Removed old comment.
23dbe9d
@realcr
Initial ideas for protocol changes. Not compiling yet.
25a58ea
@realcr
Removed currency field from RequestSendFundsOp (Signed but not present).
ce5c4ad
@realcr
offst-proto compiles: Adjusted Rust structs to capnp messages.
1aae401
@realcr
offst-proto: Removed old comment.
62e34bd
@realcr
offst-proto: Added code for Currency struct.
b03852e
@realcr
offst-proto: Removed old comments.
2858b09
@realcr
CurrencyOperations: Changed fields to be public.
84be056
@realcr
offst-signature: Updated implementation of operations_hash().
74e39a5
@realcr
Initial ideas for TokenInfo. Not done yet.
6b249dc
@realcr
Some work on funder structs on offst-proto.
444eadf
@realcr
Adjusted offst-signature (Now compiles).
ee51a5f
@realcr
offst-funder: Initial work on multi-currencies.
910049a
@realcr
offst-funder: Added currency field to MutualCredit.
eec14cd
@realcr
Added missing MoveToken field (opt_add_active_currencies).
f08170a
@realcr
Added missing opt_add_active_currencies field.
01271ab
@realcr
Some work on token_channel.rs. Not compiling yet.
6ba0aa4
@realcr
offst-funder: Some work on making token_channel compile
ef2c93a
@realcr
offst-funder: Tracking ActiveCurrencies in token-channel.
a7e701a
@realcr
offst-funder: Added some mutations to token_channel (Related to addin…
32161f1 
…g new currencies).
@realcr
offst-funder: Arranged some code before larger modification.
9b53d80
@realcr
offst-funder (token_channel): Initial ideas for TcBorrow design. Not …
64a83a8 
…compiling yet.
@realcr
offst-funder: token_channel: Using Tc{In,Out}Borrow.
0a73b33
@realcr
offst-funder token_channel: Dealing with new active currencies.
53f8f3c
@realcr
offst-funder: Fixes to token_channel test. Not done yet.
27caf6c
@realcr
offst-funder: set_remote_max_debt21() now compiles. Test doesn't pass.
85a60bf
@realcr
offst-funder: token_channel: Added expected_token_info verification. …
fd879f6 
…Not done yet.
@realcr
offst-funder: mutual-credit: TODO comments.
50db64e
@realcr
offst-funder: token_channel: Updated create_unsigned_move_token(). No…
67a7b49 
…t done yet.
@realcr
offst-funder: token_channel: Added TODO comment for create_unsigned_m…
0e15925 
…ove_token().
realcr added 27 commits October 20, 2019 23:23
@realcr
report.capnp: Removed redundant import.
3b97ac5
@realcr
offst-proto: Fixed schema comment.
9ac30d3
@realcr
offst-proto: Changes to currencies API.
2467ce1
@realcr
offst-proto: Refactoring: CurrencyReport. Not done yet.
c182f33
@realcr
offst-funder: API updates. Compiles without tests.
1c89bd9
@realcr
offst-funder: Tests compile, but some tests don't pass.
be0ce70
@realcr
offst-funder: Fixed bug in control_set_friend_currency_rate().
aeea59d
@realcr
offst-funder: Updated pair_inconsistency test.
2b08a21
@realcr
offst-funder: Added missing updates to currency_configs during resets…
cd901b3 
…. Tests now

pass.
@realcr
Adjusted the rest of offst for API changes.
4bd98cd
@realcr
offst-stctrl: Added config command: RemoveFriendCurrency.
1cfdca5
@realcr
offst-funder: Using remove_friend_currency() inside a test.
0833180
@realcr
offst-net: Removed env_logger initialization from test.
9dd4815
@realcr
offst-test: nodes_chain: Removed env_logger::init() from test.
1e5ce13
@realcr
Implemented Debug for InvoiceFile.
b1873e2
@realcr
offst-funder: implemented FromStr for Currency.
be4ee74
@realcr
offst-net: Implemented FromStr for NetAddress.
dc2ba3f
@realcr
offst-stctrl: Fixed bugs in TOML serialization of structures containi…
3da4676 
…ng Currency.
@realcr
offst-app: Exporting more structs from proto::funder.
226e117
@realcr
offst-stctrl: Added test_serialize_token_file().
0406cca
@realcr
offst-proto, offst-stctrl: Fixed TOML serialization issues.
adf8031
@realcr
offst-test: basic_cli now passes.
469b1a1
@realcr
offst-funder: Showing handler errors as warning logs.
c75767f
@realcr
offst-test: basic_cli: Added basic test code for adding/removing a cu…
de56536 
…rrency.
@realcr
offst-net: tests: Removed unused import.
8814f0f
@realcr
Fixed clippy warnings.
66efe72
@realcr
cargo fmt
d568257
@realcr realcr changed the title Initial work on multi-currency feature Multi Currency feature Oct 21, 2019
@realcr realcr merged commit efcdbd1 into master Oct 21, 2019
@realcr realcr mentioned this pull request Oct 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@realcr