Reduce MultiCommit into Commit - #242
Merged
Merged
Conversation
…_commit_signature().
… a single payment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing Commit out-of-band message to be of constant size (Previously the size depended on the amount of the transactions used for the payment). Tracking of payment sum is moved into the Funder's logic.
In the previous implementation we used a MultiCommit, which contained a set of Commits.
The new implementation adds the
is_completefield to the Response message. This allows to create a trustworthy Commit message from only one Response (and hence, from only one signature).