Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce MultiCommit into Commit #242

Merged
merged 17 commits into from Oct 26, 2019
Merged

Reduce MultiCommit into Commit #242

merged 17 commits into from Oct 26, 2019

Conversation

@realcr
Copy link
Collaborator

realcr commented Oct 26, 2019

Changing Commit out-of-band message to be of constant size (Previously the size depended on the amount of the transactions used for the payment). Tracking of payment sum is moved into the Funder's logic.

In the previous implementation we used a MultiCommit, which contained a set of Commits.
The new implementation adds the is_complete field to the Response message. This allows to create a trustworthy Commit message from only one Response (and hence, from only one signature).

@realcr realcr merged commit b607abf into master Oct 26, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
codecov/project 90.32% (+0.03%) compared to efcdbd1
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.