569 search incidents only

[melinath]

Made search page configurable sitewide as a link to an IncidentIndexPage. Set that up to be used across the board for search / recent incident lists instead of HomePage.incident_index_page.

Tradeoff: This means the search bar from the top of the page will no longer search for non-incident content. However, I think that the benefit of the more powerful incident search outweighs the loss of non-incident search, since this is a site primarily for press freedom incidents. I also think that this is what was being asked for, though I could be wrong.

Resolved #569.

[petersterne]

@melinath Just chiming in to say that you're correct. That's what I was asking for.

[melinath]

@petersterne great, thanks!

[raq929]

Talk to me a little bit about your approach here?

[melinath]

I made the header search bar go to the "all incidents" page instead of a separate search view. This makes the user experience more fluid because it means that they have immediate access to the full power of the incident search interface, as well as the standard incident display, rather than getting a variety of content with very little styling or details.

In order to accomplish this, the all incidents page needed to be a site setting rather than a homepage attribute. And once this change was implemented, the search view became vestigial and removable.

[raq929]

Looks goo d to me. I'm going to add an issue about the possibility of somehow adding blog posts to this search view eventually. Before you merge, can you put a note in the README about how search works, since it is now different from what I would expect as an incoming developer on the project?