Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate securedrop-admin to Python 3 #3489

Closed
redshiftzero opened this issue May 30, 2018 · 4 comments · Fixed by #4867
Closed

Migrate securedrop-admin to Python 3 #3489

redshiftzero opened this issue May 30, 2018 · 4 comments · Fixed by #4867
Labels
Milestone

Comments

@redshiftzero
Copy link
Member

@redshiftzero redshiftzero commented May 30, 2018

Description

We need to migrate away from Python 2 entirely, as it EOLs in 2020. This ticket is to migrate the securedrop-admin CLI tool to Python 3. The good news is that Python 3 is in Tails already (indeed the SecureDrop GUI updater in Tails uses Python 3), so this is a migration that can be done relatively soon.

@redshiftzero redshiftzero added the Python label May 30, 2018
@kneitinger

This comment has been minimized.

Copy link

@kneitinger kneitinger commented Sep 18, 2018

I've been working on this issue and have the code, install scripts, and tests ported over to python3 (which can be viewed here), with all tests passing , but am curious about if some other considerations should be included in this.

  • prompt_toolkit recently had an API-breaking update, would it be helpful to include that update as well?
  • bootstrap.py seems like it could be easier to maintain and modify if it were an ansible playbook, is there any specific reason the current design choice was made? Edit: in thinking about it more, I feel it is favorable to have an install script that doesn't have any dependencies to run it.
    Thanks
@kushaldas

This comment has been minimized.

Copy link
Contributor

@kushaldas kushaldas commented Feb 27, 2019

@kneitinger How much work do you think it will be to move to the newer prompt_toolkit?

@kneitinger

This comment has been minimized.

Copy link

@kneitinger kneitinger commented Mar 5, 2019

I do not think it would be too much work at all to transition over to the new interface, but if I recall correctly my question was more feeling out if you folks have any internal processes about package versions used.

@conorsch

This comment has been minimized.

Copy link
Contributor

@conorsch conorsch commented Jun 10, 2019

After the tooling has been migrated to Py3, we'll have to handle the transition of the virtualenv on Admin Workstations from py2 -> py3, as well. Will open a separate issue to track.

@eloquence eloquence added this to Current sprint - 9/19 - 10/9 in SecureDrop Team Board Sep 19, 2019
@kushaldas kushaldas mentioned this issue Sep 25, 2019
2 of 13 tasks complete
SecureDrop Team Board automation moved this from Current sprint - 9/19 - 10/9 to Done Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.