Setup GPG encrypted OSSEC Email Alerts #289

Closed
wants to merge 19 commits into
from

Conversation

Projects
None yet
4 participants

chrisng commented Jan 27, 2014

No description provided.

@@ -84,7 +84,7 @@ if [ "$ROLE" = 'monitor' ]; then
cat /var/lib/tor/hidden_service/hostname
echo "The Monitor Server's installation is complete."
-elif [ $ROLE = 'app' ]; then
+elif [[ $ROLE == 'app' ]]; then
@garrettr

garrettr Jan 28, 2014

Contributor

Yikes! @dolanjs is this a hotfix?

@dolanjs

dolanjs Jan 29, 2014

Contributor

not a hotfix. though it proper syntax.

Contributor

garrettr commented Jan 28, 2014

@dolanjs Can you review this now? I'll take a closer look later, but it's really up to you.

Contributor

garrettr commented Jan 28, 2014

I would prefer to not add ruby as a dependency, but those RSpec tests are awfully nice.

Contributor

dolanjs commented Jan 29, 2014

@garrettr I'd rather not add ruby as a dependency, but maybe there is a middle ground cause we really do need the server tests. Maybe only using RSpec for the dev environments and not production installations?

chrisng commented Jan 30, 2014

The RSpec test should only be loaded for the dev for TDD to ensure that the installers work correctly. You don't need them as part of the package that would get deployed or installed.

Contributor

gnusosa commented Mar 6, 2014

Can we port spec/spec_helper.rb and the specs to https://pypi.python.org/pypi/envassert with unittests? I don't know how it would work if we have to set of different packages from other languages if we ever package SecureDrop.

Contributor

dolanjs commented Oct 11, 2014

Going to close this pr since we have incorporated @chrisng gpg encrypt ossec alerts and @maxamg has taken over starting off the serverspec/rspec tests.

@dolanjs dolanjs closed this Oct 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment