Setup GPG encrypted OSSEC Email Alerts #289
Conversation
This reverts commit 39aa8aa.
…ssec-email-gpg * 'develop' of github.com:freedomofpress/securedrop: test.py is now test.sh Fixing wrong bash syntax. Oops. Added .vagrant to gitignore forgot quotes fix busted random generation in travis manifest added localhost to localhost udp iptables rules for monitor server added iptables rule for ntp Conflicts: .gitignore
| @@ -84,7 +84,7 @@ if [ "$ROLE" = 'monitor' ]; then | |||
| cat /var/lib/tor/hidden_service/hostname | |||
| echo "The Monitor Server's installation is complete." | |||
|
|
|||
| elif [ $ROLE = 'app' ]; then | |||
| elif [[ $ROLE == 'app' ]]; then | |||
There was a problem hiding this comment.
Yikes! @dolanjs is this a hotfix?
There was a problem hiding this comment.
not a hotfix. though it proper syntax.
|
@dolanjs Can you review this now? I'll take a closer look later, but it's really up to you. |
|
I would prefer to not add ruby as a dependency, but those RSpec tests are awfully nice. |
|
@garrettr I'd rather not add ruby as a dependency, but maybe there is a middle ground cause we really do need the server tests. Maybe only using RSpec for the dev environments and not production installations? |
|
The RSpec test should only be loaded for the dev for TDD to ensure that the installers work correctly. You don't need them as part of the package that would get deployed or installed. |
|
Can we port spec/spec_helper.rb and the specs to https://pypi.python.org/pypi/envassert with unittests? I don't know how it would work if we have to set of different packages from other languages if we ever package SecureDrop. |
No description provided.