New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

width of login input boxes in admin/journalist login pages increased to 550px to accomodate long passphrases #3761

Merged
merged 2 commits into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@abhn
Copy link
Contributor

abhn commented Aug 31, 2018

Status

Ready for review

Description of Changes

Fixes #3711

Changes proposed in this pull request:
increased size of login text boxes to 550px to accommodate the longer passphrases

Testing

  • Open the admin login panel, try to enter the long passphrase.
  • Passphrase fits in the input

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@abhn abhn requested review from heartsucker and redshiftzero as code owners Aug 31, 2018

@abhn abhn changed the title updating width of login input boxes in admin/journalist login pages increased to 550px to accomodate long passphrases Aug 31, 2018

@redshiftzero
Copy link
Member

redshiftzero left a comment

Hey this looks great so far @abhn!

I read through the discussion in #3711, and reducing the size of the username and OTP form fields makes sense (as @huertanix and @SaptakS were suggesting). Let's do that in this PR prior to merge. What do you think?

@abhn

This comment has been minimized.

Copy link
Contributor

abhn commented Sep 5, 2018

@redshiftzero awesome. I will update the PR shortly. Thanks!

@abhn

This comment has been minimized.

Copy link
Contributor

abhn commented Sep 6, 2018

@redshiftzero I've updated the PR. This is how the login is looking now: https://imgur.com/aiDU8VFl.png Let me know what you think, or if there are any other changes.

@redshiftzero
Copy link
Member

redshiftzero left a comment

looks great, thanks for the contribution @abhn

@redshiftzero redshiftzero merged commit 7601a06 into freedomofpress:develop Sep 7, 2018

5 checks passed

ci/circleci: admin-tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: staging-test-with-rebase Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
ci/circleci: updater-gui-tests Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment