New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uuid to reply endpoint #3917

Merged
merged 3 commits into from Nov 2, 2018

Conversation

Projects
None yet
2 participants
@heartsucker
Copy link
Contributor

heartsucker commented Nov 2, 2018

Status

Ready for review

Description of Changes

Fixes #3915

Adds the uuid to the response when creating a reply so that the reply can be referenced later.

Somewhat related, should we really be sending message in the JSON? Because I feel like that human readable text doesn't need to be there if the HTTP codes are present. It also is confusing in this case. Is message related to what I posted? We have two fields, and message seems ambiguous / redundant.

Testing

Post a reply, observe UUID present. Run tests.

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
  2. New installs.

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

@heartsucker heartsucker requested a review from redshiftzero as a code owner Nov 2, 2018

@redshiftzero
Copy link
Member

redshiftzero left a comment

looks good!

heartsucker added some commits Nov 2, 2018

@redshiftzero
Copy link
Member

redshiftzero left a comment

rebased after merging #3921, restamping

@redshiftzero redshiftzero merged commit 3fb4a91 into develop Nov 2, 2018

5 checks passed

ci/circleci: admin-tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: staging-test-with-rebase Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
ci/circleci: updater-gui-tests Your tests passed on CircleCI!
Details

@redshiftzero redshiftzero deleted the reply-uuid branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment