New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ansible to 2.6.8 #3945

Merged
merged 3 commits into from Nov 28, 2018

Conversation

Projects
None yet
4 participants
@emkll
Copy link
Contributor

emkll commented Nov 28, 2018

Status

Ready for review

Description of Changes

Fixes #3891 .

Upgrades Ansible to 2.6.8 for SecureDrop admin tools. There is currently an issue with Ansible 2.7 series where builders can't be run concurrently to due timeout of get_mount_facts. Let's update to 2.6.x since it's still fully supported (bugs and security fixes), since the window for 0.11.0 is rapidly closing.

Testing

  • CI should pass
  • Install the dependencies listed in develop-requirements.txt to upgrade your local ansible version
  • make build-debs completes without error (except the builder image updates)
  • Clean install
  • Hash for ansible version (in admin/requirements.txt) is correct
  • ./securedrop-admin backup and ./securedrop-admin restore should be functional

Deployment

  1. For SecureDrop instances, it is deployed to admin workstations via ./securedrop-admin update
  2. Dev env will need to be updated by installing the requirements in securedrop/requirements/develop-requirements.txt

Checklist

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR
Update Ansible to 2.6.8
Also update molecule and testinfra

emkll added some commits Nov 28, 2018

Replace deprecated ansible commands
state:running was deprecated in ansible 2.5, replaced by state:started.

@emkll emkll force-pushed the 3891-ansible-2.6 branch from 05c86dc to 9b72bbd Nov 28, 2018

@conorsch conorsch referenced this pull request Nov 28, 2018

Closed

Upgrade ansible to 2.7.2 #3944

3 of 7 tasks complete
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #3945 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3945   +/-   ##
========================================
  Coverage    84.55%   84.55%           
========================================
  Files           43       43           
  Lines         2726     2726           
  Branches       296      296           
========================================
  Hits          2305     2305           
  Misses         354      354           
  Partials        67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7ffda...9b72bbd. Read the comment docs.

@redshiftzero
Copy link
Member

redshiftzero left a comment

CI should pass
Install the dependencies listed in develop-requirements.txt to upgrade your local ansible version make build-debs completes without error (except the builder image updates)
Clean install (on macOS with VirtualBox)
Hash for ansible version (in admin/requirements.txt) is correct:

$ shasum -a 256 ansible-2.6.8.tar.gz
012649806427e630ef8e8b71d42483af882bc39ade3b19e1f369b14c0afd5b87  
@redshiftzero

This comment has been minimized.

Copy link
Member

redshiftzero commented Nov 28, 2018

We discussed in chat that the backup and restore flow we can test as part of regular pre-release testing for 0.11.0

@conorsch
Copy link
Contributor

conorsch left a comment

  • CI should pass
  • Install the dependencies listed in develop-requirements.txt to upgrade your local ansible version
  • make build-debs completes without error (except the builder image updates)
  • Clean install
  • Hash for ansible version (in admin/requirements.txt) is correct :
$ sha256sum ansible-2.6.8.tar.gz 
012649806427e630ef8e8b71d42483af882bc39ade3b19e1f369b14c0afd5b87  ansible-2.6.8.tar.gz
$ grep 012649806427e630ef8e8b71d42483af882bc39ade3b19e1f369b14c0afd5b87 -B1 admin/requirements.txt 
ansible==2.6.8 \
    --hash=sha256:012649806427e630ef8e8b71d42483af882bc39ade3b19e1f369b14c0afd5b87
$ echo $?
0

  • 🔶 ./securedrop-admin backup and ./securedrop-admin restore should be functional Did not test; deferring to QA period

@redshiftzero redshiftzero merged commit 2ae5316 into develop Nov 28, 2018

5 checks passed

ci/circleci: admin-tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: staging-test-with-rebase Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
ci/circleci: updater-gui-tests Your tests passed on CircleCI!
Details

@redshiftzero redshiftzero deleted the 3891-ansible-2.6 branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment