Removes virtualbox support in VM scenarios #5922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5922 +/- ##
========================================
Coverage 85.37% 85.37%
========================================
Files 53 53
Lines 3876 3876
Branches 480 480
========================================
Hits 3309 3309
Misses 455 455
Partials 112 112 Continue to review full report at Codecov.
|
conorsch
pushed a commit
to freedomofpress/securedrop-docs
that referenced
this pull request
May 4, 2021
Supplements freedomofpress/securedrop#5922. Edits the dev docs to remove explicit mentions of Virtualbox, preferring Libvirt (or Qubes) for any of the VM docs. Mostly this affects the macOS docs. For macOS, we're now more clearly directing folks to use the container dev env.
conorsch
pushed a commit
to freedomofpress/securedrop-docs
that referenced
this pull request
May 4, 2021
Supplements freedomofpress/securedrop#5922. Edits the dev docs to remove explicit mentions of Virtualbox, preferring Libvirt (or Qubes) for any of the VM docs. Mostly this affects the macOS docs. For macOS, we're now more clearly directing folks to use the container dev env.
3 tasks
The team isn't using virtualbox actively, and for e.g. macos we have a much more convenient docker dev env for making app code changes. Let's remove virtualbox support entirely, until we have a pressing reason for it.
conorsch
force-pushed
the
5904-remove-virtualbox
branch
from
94588c8
to
aafbe73
Compare
|
Marking as ready for review. Note that related docs changes are in freedomofpress/securedrop-docs#216, which is currently blocked by review on freedomofpress/securedrop-docs#214. Still, these changes can be reviewed on their own, so I'm not tagging this PR as blocked. |
|
End of an era! Glad to see it go. Hopefully the newer infra is faster and more reliable! |
conorsch
pushed a commit
to freedomofpress/securedrop-docs
that referenced
this pull request
May 11, 2021
Supplements freedomofpress/securedrop#5922. Edits the dev docs to remove explicit mentions of Virtualbox, preferring Libvirt (or Qubes) for any of the VM docs. Mostly this affects the macOS docs. For macOS, we're now more clearly directing folks to use the container dev env.
sssoleileraaa
approved these changes
May 19, 2021
| @@ -31,6 +31,8 @@ | |||
| tags: | |||
| - dns | |||
|
|
|||
| # These services will be inside staging VMs via the Bento boxes, | |||
| # even if those boxes are running on libvirt. | |||
| # Default to VirtualBox, since it's the safest bet. | ||
| securedrop_vm_provider="virtualbox" | ||
| # We previously maintained Virtualbox support, but don't any longer. Should we? | ||
| echo "WARNING: Unsupported platform. Libvirt staging environment may not work properly." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review.
Description of Changes
Towards #5904. In combination with freedomofpress/securedrop-docs#216, closes #5904.
Changes proposed in this pull request:
The team isn't using virtualbox actively, and for e.g. macos we have a
much more convenient docker dev env for making app code changes.
Let's remove virtualbox support entirely, until we have a pressing
reason for it.
Testing
These are mostly removals, building on changes in #5911. One important workflow to make sure we haven't broken is to provision prod VMs, and configure them via a virtualized Tails Admin Workstation. I've tested that myself, before opening this PR, and am satisfied with the behavior. Anyone else with a Debian Stable machine is welcome to try the same.
Deployment
Dev-only.