Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upload-screenshots.py from package #5941

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented May 15, 2021

Status

Ready for review

Description of Changes

Fixes #5832

Uses .rsync-filter as suggested by @conorsch on #5832 (comment). We could also move the script somewhere else, but none of the existing directories (e.g., devops) felt like a great fit.

Testing

  1. make build-debs-notest on this branch
  2. Make a coffee, read a book, ponder the mysteries of the universe
  3. Inspect securedrop-app-code package in build/focal
    • Observe that upload-screenshots.py is no longer present.

@eloquence eloquence requested a review from a team as a code owner May 15, 2021 00:21
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2021

Codecov Report

Merging #5941 (3e4fc07) into develop (6eb5ac8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5941   +/-   ##
========================================
  Coverage    85.37%   85.37%           
========================================
  Files           53       53           
  Lines         3876     3876           
  Branches       480      480           
========================================
  Hits          3309     3309           
  Misses         455      455           
  Partials       112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb5ac8...3e4fc07. Read the comment docs.

Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. make build-debs-notest on this branch
  2. Make a coffee, read a book, ponder the mysteries of the universe
  3. Inspect securedrop-app-code package in build/focal
    • Observe that upload-screenshots.py is no longer present.

@rmol rmol merged commit 1470aa8 into develop May 17, 2021
@rmol rmol deleted the 5832-no-screenshot-script branch May 17, 2021 18:24
@zenmonkeykstop zenmonkeykstop mentioned this pull request Jun 14, 2021
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshot utility script should be removed from packages
3 participants