-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds /sources/<source_uuid>/conversation endpoint supporting DELETE #5963
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5963 +/- ##
===========================================
- Coverage 85.34% 85.32% -0.03%
===========================================
Files 53 53
Lines 3875 3883 +8
Branches 480 481 +1
===========================================
+ Hits 3307 3313 +6
- Misses 456 457 +1
- Partials 112 113 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is good, with proper test cases. We will also need a corresponding PR for the docs repo in the API section.
I will do a formal review after it is marked as "ready for review"
thanks @kushaldas, test plan etc in progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Test plan passes, works with WIP client safe deletion changes.
Status
Work in progress
Description of Changes
Adds an API endpoint
/sources/<source_uuid>/conversation
, which, when called via the DELETE method, deletes all submissions and replies while preserving the source account. All other methods just return a405
.Testing
Dev container:
make dev
on this branchhttp://localhost:8081
in a browserpip install pyotp requests
, and run it withpython3 wipe-convo.py
method not allowed
, and the application log inmake dev
output shows a405
status code for the requestEnter
when prompted by the script to run the DELETE requestsource data deleted
, and the application log inmake dev
output shows a200
status code for the requestDeployment
Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development containerIf you made non-trivial code changes:
Choose one of the following: