-
Notifications
You must be signed in to change notification settings - Fork 704
Support new vagrant and ansible versions #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into support-vagrant-1.7+ Conflicts: docs/develop.md
Gotta say this is a great first pull request! And perfect timing too, for reasons that should become clear later this week :)
Yeah, I agree it would be good to add that. I'll add a commit with a warning about that before merging this. |
Added a commit with the warning about Ansible 1.5.4 being default package in Ubuntu 14.04, and ended up cleaning up and clarifying a lot of |
@ageis K, will do |
@conorsch FYI, I'm still not sure |
Here's an example of why I prefer develop to be the default: Github's autoclose syntax only works when commits are merged into the default branch (ref). |
After reading some more Github docs, I realized that develop really should be the default branch. Github assumes that "default branch" = "branch code gets merged in to", which is When the default branch is master, then the following undesirable things happen (there are probably even more than we just haven't encountered yet):
|
This absolutely should have been submitted to |
This PR makes a one-line change to the Vagrantfile that disables dynamic SSH key substitution in recent (1.7.0+) versions of vagrant. This problem was discussed in #802, and we've been recommending that developers use vagrant 1.6.5 since then. Downgrading isn't necessary, since we can toggle the key substitution by setting:
config.ssh.insert_key = false
All VirtualBox machines managed by the Vagrantfile are affected by this change. If the keys have been substituted already, destroying and recreating the machines is the easiest way to get back in sync. To make sure that setting this option doesn't break provisioning with older versions, I tested a variety of versions of both Ansible and Vagrant. The test consisted of destroying all VMs, setting the desired ansible and vagrant versions, then creating and provisioning all machines.
I was able to create and fully provision all machines with these version combinations:
This version combination failed (due to an
apache2_module
call):Based on those results, I'm comfortable recommending the newest versions of both vagrant and ansible, and have updated the development docs to say so.
Caveats
apache2_module
was added in 1.6) and it's currently the default in the repos for Ubuntu 14.04.config.ssh.insert_key = false
should not break SSH key insertion viaoverride.ssh.private_key_path
, as in the case of the Digital Ocean box, but keep an eye out for regressions on that box just in case.This change resolves #802 and resolves #906.