From eb4046cc6e7a42fc4e6449c15901e224f50b2b63 Mon Sep 17 00:00:00 2001
From: Garrett Robinson <garrett.f.robinson@gmail.com>
Date: Fri, 9 Jun 2017 00:41:58 -0700
Subject: [PATCH 1/3] Copy shares with Electron's clipboard API

---
 src/components/CopyButton.js | 30 +++++-------------------------
 1 file changed, 5 insertions(+), 25 deletions(-)

diff --git a/src/components/CopyButton.js b/src/components/CopyButton.js
index 3d3eff5..a9bd664 100644
--- a/src/components/CopyButton.js
+++ b/src/components/CopyButton.js
@@ -1,4 +1,5 @@
 import React, { Component } from 'react';
+const {clipboard} = require('electron');
 import PropTypes from 'prop-types';
 import Button from './Button';
 
@@ -16,23 +17,11 @@ export default class CopyButton extends Component {
   }
 
   handleClicked() {
-    let successful;
-    this.copyEl.select();
-    this.copyEl.setSelectionRange(0, this.copyEl.value.length);
+    clipboard.writeText(this.props.targetText);
 
-    try {
-      successful = document.execCommand('copy');
-    } catch (e) {
-      successful = false;
-    }
-
-    if (successful) {
-      this.setState({ copied: 'successful' });
-      if (this.props.onCopied) {
-        this.props.onCopied();
-      }
-    } else {
-      this.setState({ copied: 'error' });
+    this.setState({ copied: 'successful' });
+    if (this.props.onCopied) {
+      this.props.onCopied();
     }
 
     window.setTimeout(() => this.setState({ copied: null }), 5000);
@@ -45,8 +34,6 @@ export default class CopyButton extends Component {
 
     if (copied === 'successful') {
       copyText = 'Copied';
-    } else if (copied === 'error') {
-      copyText = 'Copy failed';
     } else {
       copyText = this.props.buttonText || 'Copy';
     }
@@ -57,14 +44,7 @@ export default class CopyButton extends Component {
         onClick={this.handleClicked.bind(this)}
         {...this.props}>
         {copyText}
-        {/* hidden input for copy to clipboard functionality */}
-        <input type="text"
-          style={ { position: 'absolute', top: '-10000px', left: '-10000px' } }
-          readOnly
-          ref={(el) => (this.copyEl = el)}
-          value={this.props.targetText} />
       </Button>
-
     );
   }
 }

From 96a993c86f900487cdf5be2255414367bb3b4ca1 Mon Sep 17 00:00:00 2001
From: Garrett Robinson <garrett.f.robinson@gmail.com>
Date: Wed, 14 Jun 2017 16:17:59 -0700
Subject: [PATCH 2/3] Fix e2e test

Now that we've integrated Spectron, we can access Electron API's
directly from within the e2e tests, which makes testing
clipboard-related functionality straightforward.

I added the className to CopyButton and unique id's to each ShareRow to
make it easier to construct an explicit WebdriverIO selector. I think
explicit selectors (and correspondingly, careful design of classes and
ID's) are good because they make tests easier to read and reason about,
and reduce the likelihood of test failures due to imprecise selectors.
---
 src/components/CopyButton.js |  1 +
 src/components/ShareRow.js   |  2 +-
 test/e2e.js                  | 12 ++++++++----
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/components/CopyButton.js b/src/components/CopyButton.js
index a9bd664..6cc364a 100644
--- a/src/components/CopyButton.js
+++ b/src/components/CopyButton.js
@@ -40,6 +40,7 @@ export default class CopyButton extends Component {
 
     return (
       <Button type="default"
+        className="copy"
         icon="clipboard"
         onClick={this.handleClicked.bind(this)}
         {...this.props}>
diff --git a/src/components/ShareRow.js b/src/components/ShareRow.js
index e73f965..5e0ffe3 100644
--- a/src/components/ShareRow.js
+++ b/src/components/ShareRow.js
@@ -56,7 +56,7 @@ export default class ShareRow extends Component {
     }
 
     return (
-      <div className="share-row" key={share}>
+      <div className="share-row" key={share} id={`share-${index}`}>
         <div className="share-cell share-value">
           {`Share #${index}`}
           <span className="share-status">
diff --git a/test/e2e.js b/test/e2e.js
index f0e19f6..34e5835 100644
--- a/test/e2e.js
+++ b/test/e2e.js
@@ -7,7 +7,8 @@ const appPath = path.join(__dirname, '..');
 
 describe('main window', function spec() {
   this.timeout(5000);
-  let shares; // Store the generated shares for recovery
+
+  let shares = []; // Store the generated shares for recovery
   const quorum = 2;
   const numShares = 3;
   const secret = 'test secret';
@@ -49,9 +50,12 @@ describe('main window', function spec() {
     expect(shareEls.value).to.have.length(3);
   });
 
-  it('should find and store the share values', async () => {
-    // Depends on implementation of the copy button, less than ideal.
-    shares = await app.client.getAttribute('input[readonly]', 'value');
+  it('should copy the share values to the clipboard and store them', async () => {
+    for (let i = 0; i < quorum; i++) {
+      await app.client.element(`#share-${i+1} .copy`).click();
+      const share = await app.electron.clipboard.readText();
+      shares.push(share);
+    }
   });
 
   it('should go back to the home screen', async () => {

From 6120899d3150b20c4fa8789cd8bd665777fb5317 Mon Sep 17 00:00:00 2001
From: Garrett Robinson <garrett.f.robinson@gmail.com>
Date: Wed, 14 Jun 2017 16:28:43 -0700
Subject: [PATCH 3/3] Add test for copying the recovered secret

---
 test/e2e.js | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/test/e2e.js b/test/e2e.js
index 34e5835..307c4c0 100644
--- a/test/e2e.js
+++ b/test/e2e.js
@@ -93,5 +93,14 @@ describe('main window', function spec() {
     await app.client.waitForVisible('.secret-view');
     const foundSecret = await app.client.getAttribute('.secret-view', 'value');
     expect(foundSecret).to.be.eql(secret);
+    await app.client.element('.btn*=Hide').click();
+  });
+
+  it('should be able to copy the recovered secret', async () => {
+    // Make sure the clipboard is clear before copying
+    await app.electron.clipboard.clear();
+    await app.client.element('.copy').click();
+    const copiedSecret = await app.electron.clipboard.readText();
+    expect(copiedSecret).to.be.eql(secret);
   });
 });