Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple offer currency and payment currency. #157

Closed
tonylampada opened this issue May 22, 2013 · 16 comments

Comments

Projects
None yet
3 participants
@tonylampada
Copy link
Member

commented May 22, 2013

Offers made in US$, can only be paid in US$, using Paypal.
Offers made in Bitcoin can only be paid in BTC.

This means that FS doesn't support BTC as a payment method for offers in US$.

There's no reason for this limitation to exist.
Users should be able to use BTC to pay for offers in US$ (and possibly vice-versa)

@tonylampada

This comment has been minimized.

Copy link
Member Author

commented May 22, 2013

I'm working on a new payment screen to address this.
I'll post it here as soon as it's ready for show.

tonylampada added a commit that referenced this issue May 26, 2013

tonylampada added a commit that referenced this issue May 26, 2013

@tonylampada

This comment has been minimized.

Copy link
Member Author

commented May 26, 2013

A mocked, but somewhat functional payment screen is available at:
http://www.freedomsponsors.org/core/offer/pay_angular

This is supposed to be a payment screen for a US$ 20,00 offer that has been claimed to be solved by two programmers.

On this screen, the sponsor can select on which currency to pay.
The "Confirm payment details" section (on the right hand side) displays a summary of payment amounts and fees before the sponsors makes the payment.

Any feedback is appretiated!

@iurisilvio

This comment has been minimized.

Copy link
Contributor

commented May 26, 2013

This new screen looks good! 👍

@tonylampada

This comment has been minimized.

Copy link
Member Author

commented May 26, 2013

really?! :-)
Thanks!

@tonylampada

This comment has been minimized.

Copy link
Member Author

commented May 26, 2013

I've been learning how to use AngularJS - and think it's really great.
So I used it a lot on that scren to make it as interactive/responsive as I think it should be.

I'll probably be using Angular a lot more on other pages too.

@campadrenalin

This comment has been minimized.

Copy link

commented May 27, 2013

Obviously needs work before we're ready to switch to it, but I for one would love this. Being able to pay everything with Bitcoin would be super freeing, since it would no longer matter what workers want to be paid in.

@tonylampada

This comment has been minimized.

Copy link
Member Author

commented May 27, 2013

Being able to pay everything with Bitcoin would be super freeing, since it would no longer matter what workers want to be paid in.

I'd love that too. This improvement is a step in that direction but it doesn't get us there yet.

It will let you pay in Bitcoins - as long the programmer accepts them (meaning: the programmer must have filled a bitcoin address on their profile page).
FreedomSponsors will still be just forwarding payments in the same currency that you pay. Only now there'll be a suggested USD/BTC conversion rate.

This new screen tries to make this clear when you select "Bitcoin" on "Select currency to pay" (did you see the "Heads up" popover balloon?). It also enforces the "programmers' accepted currencies" constraints.

The perfect scenario is the one where you'd pay in Bitcoins, and the programmer would receive in US$ (if so desired). We're just not there - yet.

@campadrenalin

This comment has been minimized.

Copy link

commented May 27, 2013

I didn't realize that at all. I think the design could use a bit of clarity about this, and not hide such an important caveat in a popover.

@tonylampada

This comment has been minimized.

Copy link
Member Author

commented May 27, 2013

That's exactly the kind of outside view that I need. Thanks for the feedback!

@tonylampada

This comment has been minimized.

Copy link
Member Author

commented May 28, 2013

I've updated the new payment page (replaced the popover with a popup).
That's better, right?

Also, I created #164 for "disambiguation".

@campadrenalin

This comment has been minimized.

Copy link

commented May 29, 2013

Sponsored!

On Tue, May 28, 2013 at 4:34 PM, tonylampada notifications@github.comwrote:

I've updated the new payment page (replaced the popover with a popup).
That's better, right?

Also, I created #164https://github.com/freedomsponsors/www.freedomsponsors.org/issues/164for "disambiguation".


Reply to this email directly or view it on GitHubhttps://github.com//issues/157#issuecomment-18587207
.

tonylampada added a commit that referenced this issue Jun 5, 2013

tonylampada added a commit that referenced this issue Jun 10, 2013

tonylampada added a commit that referenced this issue Jun 10, 2013

tonylampada added a commit that referenced this issue Jun 10, 2013

tonylampada added a commit that referenced this issue Jun 10, 2013

tonylampada added a commit that referenced this issue Jun 14, 2013

tonylampada added a commit that referenced this issue Jun 14, 2013

tonylampada added a commit that referenced this issue Jun 14, 2013

tonylampada added a commit that referenced this issue Jun 14, 2013

tonylampada added a commit that referenced this issue Jun 14, 2013

tonylampada added a commit that referenced this issue Jun 14, 2013

tonylampada added a commit that referenced this issue Jun 15, 2013

tonylampada added a commit that referenced this issue Jun 15, 2013

tonylampada added a commit that referenced this issue Jun 15, 2013

@tonylampada

This comment has been minimized.

Copy link
Member Author

commented Jun 15, 2013

Done, let's see if it works...

@campadrenalin

This comment has been minimized.

Copy link

commented Jun 17, 2013

Do you mind if I pay the bounty for this issue in BTC? There's some amount of risk in doing functional test and bounty reward in one fell swoop, but I have faith!

@tonylampada

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2013

I would actually love it if you pay in Bitcoins.
Please do!
Thanks!

@tonylampada

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.