Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorblind-friendly keys, door indicators and HUD icons #755

Merged
merged 5 commits into from
Aug 22, 2021

Conversation

slashdevslashurandom
Copy link
Contributor

This pull request will change the keycards to be more accessible for colorblind users.

  • The red key now has a horizontal line on it, the yellow key a vertical line, and the blue key has a cross shape. The HUD icons for these keys have been redrawn.
  • The skull key HUD icons now look more like the actual skull keys, with different horns and shapes on each.
  • The key-colored door indicators now also have a horizontal/vertical/X-shaped pattern drawn on them.

@fragglet
Copy link
Member

This is really cool work and I strongly support making Freedoom more accessible!

Do we have all the key indicator wall textures covered? We should make sure we aren't missing any.

For those who aren't colorblind (I'm not) there are colorblindness simulator websites. Here are some screenshots of the new keys and door indicators with Deuteranopia (most common form of colorblindness) and Achromatopsia (total colorblindness):

Screen Shot 2021-08-17 at 11 36 08 AMScreen Shot 2021-08-17 at 11 39 53 AM

Screen Shot 2021-08-17 at 11 36 29 AMScreen Shot 2021-08-17 at 11 40 01 AM

Should we try to make the indicator lines brighter for the red and blue cases?

@slashdevslashurandom
Copy link
Contributor Author

slashdevslashurandom commented Aug 17, 2021

  1. In later commits, I made it so that the inside-the-circle lines on the keys are already gray (and bright enough), so they're easier to differentiate. @fragglet 's comparison image uses the older versions.

  2. The skull key indicator textures are not changed, but that's because these seem to be derived from an actual photo of a skull and colorized, and I don't think I can make the necessary changes. (If I had the choice, I'd make it so that the skulls instead look like the skull keys themselves, which all have different shapes and horns.)

keys with red-blindness simulated keys with monochromacy simulated

@Xindage
Copy link
Contributor

Xindage commented Aug 17, 2021

The vertical bar need some touch up, for me it's a little off

@slashdevslashurandom
Copy link
Contributor Author

The vertical bar on the doors uses a color ramp where there's just not a lot of colors. I wish I could do a better bar, but I didn't want it to look too primitive...

@slashdevslashurandom
Copy link
Contributor Author

Update: made the door key indicators more distinct. Now each of them have a noticable lighting pattern matching the lines on the keys (horizontal bar for red, vertical line for yellow, cross shape for green).

Now they only use the colors that have been used in DOOM's version of
the corresponding patches. This should prevent them from being too
bright or unnatural-looking.
@Xindage
Copy link
Contributor

Xindage commented Aug 21, 2021

it's ready to be commited?

@slashdevslashurandom
Copy link
Contributor Author

I personally would say yes, but it all depends on the project's maintainers, not me.

@chungy
Copy link
Member

chungy commented Aug 22, 2021

Looks like a pretty great addition :)

@chungy chungy merged commit 7412e75 into freedoom:master Aug 22, 2021
selliott512 pushed a commit to chexter10538/freedoom that referenced this pull request May 22, 2022
Update the W108 skull patches to make them like the skull keys added by
PR freedoom#755. This will be helpful to colorblind people.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants