Coverity: fix REVERSE_INULL for pevent->inst

[tkrizek]

With the DynDB API changes, the ldap instance is acquired
differently. Previously, obtaining the instance could fail when
LDAP was disconnecting, thus the NULL check was necessary in the
cleanup part.

Now, inst is obtained directly from the API. I'm not sure what is
the exact behaviour in edge cases such as LDAP disconnecting, so
I perform the NULL check a bit earlier, just to be safe.

[tkrizek]

@pemensik Hi, could you take a quick look at this change?

I ran coverity and the issues were fixed.

It might also be possible to remove the REQUIRE, but since I'm not sure whether inst is always non null in the new dyndb workflow, I added the check just to be sure.

[pemensik]

Hi Tomáš,

I did not find any place which could result with inst == NULL. ldap_sync_prepare contains proper REQUIRE(inst != null) and all other function uses its result stored in ls_private. I think null check does not harm anything. It is used in BIND to catch unexpected problems after code changes. I would suggest to place one require at the beginning of syncrepl_update function also.

Overall I think it should be merged.

[tkrizek]

Thanks for the review, Petr!

I added the check to syncrepl_update as well.

[tkrizek]

master:

• 13b1851