Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: remove unnecessary bind-pkcs11 dependency #16

Closed

Conversation

tkrizek
Copy link
Contributor

@tkrizek tkrizek commented Apr 7, 2017

The bind-pkcs11 dependency was originally introduced in Fedora
specfile in 2014 to help with ipa-server-upgrade. This was a
temporary workaround. Since Fedora life cycle is 13 months and
this change happened more than two years ago, it is safe to
remove the workaround.

bind-dyndb-ldap does not actually depend on bind-pkcs11, although it
is a dependency that is enforced by freeipa.

The bind-pkcs11 dependency was originally introduced in Fedora
specfile in 2014 to help with ipa-server-upgrade. This was a
temporary workaround. Since Fedora life cycle is 13 months and
this change happened more than two years ago, it is safe to
remove the workaround.

bind-dyndb-ldap does not actually depend on bind-pkcs11, although it
is a dependency that is enforced by freeipa.
@MartinBasti
Copy link

LGTM

@tkrizek tkrizek added the ack label Apr 7, 2017
@tkrizek
Copy link
Contributor Author

tkrizek commented Apr 7, 2017

master:

@tkrizek tkrizek closed this Apr 7, 2017
@tkrizek tkrizek added the pushed label Apr 7, 2017
@lslebodn
Copy link

lslebodn commented Apr 8, 2017

I am not sure whether change to "requires" is ideal. Because after installation of freeipa-dns with this spec file system will contain packages: bind and bind-pkcs11. And I doubt both will be running in the same time.

rpm 4.13 is in fedora 24+ and contains boolean dependencies
http://rpm.org/user_doc/more_dependencies.html#boolean-dependencies

@tkrizek
Copy link
Contributor Author

tkrizek commented Apr 8, 2017

@lslebodn The boolean dependencies look interesting. That seems like a better way to handle this bind / bind-pkcs11 issue. I'll take a look at it.

@MartinBasti
Copy link

@lslebodn bind-pkcs11 requires bind package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants