fix ldif syntax and add idnsTemplateAttribute #2
Conversation
| @@ -362,9 +362,16 @@ attributeTypes: ( 2.16.840.1.113730.3.8.5.31 | |||
| NAME 'idnsServerId' | |||
| DESC 'DNS server identifier' | |||
| SYNTAX 1.3.6.1.4.1.1466.115.121.1.15 | |||
| EQUALITY caseIgnoreMatch | |||
| EQUALITY caseIgnoreMatch | |||
There was a problem hiding this comment.
Please don't add whitespace at the end of line
| SINGLE-VALUE ) | ||
| # | ||
| olcattributeTypes: ( 2.16.840.1.113730.3.8.5.29 |
There was a problem hiding this comment.
You have typo there, 'olcattribute''
| @@ -426,6 +433,6 @@ objectClasses: ( 2.16.840.1.113730.3.8.6.6 | |||
| objectClasses: ( 2.16.840.1.113730.3.8.6.5 | |||
| NAME 'idnsTemplateObject' | |||
| DESC 'Template object for dynamic DNS attribute generation' | |||
| SUP top | |||
| SUP top | |||
There was a problem hiding this comment.
Same here, no extra whitespace please
| @@ -365,7 +365,7 @@ attributeTypes: ( 2.16.840.1.113730.3.8.5.31 | |||
| EQUALITY caseIgnoreMatch | |||
| SINGLE-VALUE ) | |||
| # | |||
| olcattributeTypes: ( 2.16.840.1.113730.3.8.5.29 | |||
| attributeTypes: ( 2.16.840.1.113730.3.8.5.29 | |||
There was a problem hiding this comment.
Please merge this change to previous patch
|
Hello, I wrote inline comments. Please set proper author name in commit (no root please) |
|
@mbasti-rh , the white-space at the end of line is required here because the first space at the beginning of line will be consumed by LDIF parser. I agree that root should not be author of the commit :-) |
|
so sorry for the root committer, but the white space is needed by OpenLDAP LDIF parser. I have fixed the ugly pull request. :-) Thanks. |
|
Thanks! I've commited the fix as 1771114. |
schema.ldif lost some white space in the line end.
schema.ldif lost the idnsTemplateAttribute definitition