handle termination of syncrepl watcher thread #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pspacek
suggested changes
Dec 20, 2016
| @@ -747,6 +739,25 @@ destroy_ldap_instance(ldap_instance_t **ldap_instp) | |||
| *ldap_instp = NULL; | |||
| } | |||
|
|
|||
| void watcher_shutdown(ldap_instance_t *ldap_inst) | |||
There was a problem hiding this comment.
Maybe this could be named ldap_syncrepl_watcher_shutdown so it is clear from its name where it belongs...
| * used by BIND itself. | ||
| */ | ||
| REQUIRE(pthread_kill(ldap_inst->watcher, SIGUSR1) == 0); | ||
| watcher_shutdown(ldap_inst); | ||
| RUNTIME_CHECK(isc_thread_join(ldap_inst->watcher, NULL) |
There was a problem hiding this comment.
I would move isc_thread_join into the shutdown function as well.
| @@ -747,6 +739,25 @@ destroy_ldap_instance(ldap_instance_t **ldap_instp) | |||
| *ldap_instp = NULL; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The function is missing a comment. Please add one and describe what it does and under what conditions. Please see other Doxygen-style comments for inspiration.
|
We are almost there. Just minor changes will make it perfect :-) |
|
The patch looks good to me. ACK |
pspacek
approved these changes
Dec 20, 2016
In some cases, the thread could have been already terminated and sending a signal to the thread using pthread_kill() would result in an error. Now if the thread has already been terminated for some reason, only an error message is logged. https://fedorahosted.org/bind-dyndb-ldap/ticket/149 Reviewed-By: Petr Spacek <pspacek@redhat.com> Reviewed-By: Thierry Bordaz <tbordaz@redhat.com>
|
Fixed upstream: edd8c0552eb7e977a961c9492eb18c177685e438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the thread could have been already terminated and
sending a signal to the thread using pthread_kill() would result in an
error. Now if the thread has already been terminated for some reason,
only an error message is logged.
https://fedorahosted.org/bind-dyndb-ldap/ticket/149