Support webui tests #149
Merged
Support webui tests #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicki-krizek
force-pushed
the
webui-tests
branch
3 times, most recently
from
8c6463a
to
00ecb04
Compare
|
@pvomacka Ready for review, successful run: nicki-krizek/freeipa#47 |
pvomacka
suggested changes
Dec 13, 2017
|
|
||
| # Uncomment when IPA is installed without DNS server | ||
| #no_dns: True | ||
|
|
There was a problem hiding this comment.
Could you please add configuration option for Geckodriver.log ?
# Geckodriver setup:
# =================
# log file has to be somewhere, where user has rights to write into file
geckodriver_log_path: /home/me/.ipa/geckodriver.log
and set it as PR-CI needs. We might need to collect this log in the future (or is it possible collect it right now?)
There was a problem hiding this comment.
Why, yes -- we can!
nicki-krizek
force-pushed
the
webui-tests
branch
from
00ecb04
to
b7f0cfe
Compare
added 3 commits
December 14, 2017 14:21
Install and download dependencies to run webui functional tests. https://www.freeipa.org/page/Web_UI_Integration_Tests Signed-off-by: Tomas Krizek <tkrizek@redhat.com>
Add provisioning playbook and files for webui testing. Signed-off-by: Tomas Krizek <tkrizek@redhat.com>
Add a job that can be used in the .freeipa-pr-ci.yaml config to execute webui tests. Signed-off-by: Tomas Krizek <tkrizek@redhat.com>
nicki-krizek
force-pushed
the
webui-tests
branch
4 times, most recently
from
4bd74bb
to
c4fff43
Compare
added 2 commits
December 15, 2017 14:27
Related: freeipa#146 Signed-off-by: Tomas Krizek <tkrizek@redhat.com>
Related: freeipa#146 Signed-off-by: Tomas Krizek <tkrizek@redhat.com>
nicki-krizek
force-pushed
the
webui-tests
branch
from
c4fff43
to
844196e
Compare
|
I also added support for xmlrpc Python tests, since they require a similar setup. It's possible to execute them now. This PR is ready for review. xmlrpc test run in Py2: https://fedorapeople.org/groups/freeipa/prci/jobs/4f3eba70-e19a-11e7-a866-001e4fb5bf1d/report.html |
Signed-off-by: Tomas Krizek <tkrizek@redhat.com>
nicki-krizek
force-pushed
the
webui-tests
branch
from
844196e
to
98cebde
Compare
pvomacka
approved these changes
Dec 19, 2017
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template modifications and provisioning should work fine. I'm still verifying the job definition. Once I verify it and have a passing job, I'll update the PR with a comment.